Bug 210576

Sounds like a god idea to me. Could also resolve the space problems discussed at 210358 if some kind of popup menu is used to configure the filters.

Created attachment 37592 [details]
Mockup : tags filters on status bar

This Mockup is done to take tags selector combo box from Advanced Search dialog. 

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/searchwindow/searchfields.h#301

Of course a lots of code from current tags filter tree view must be backported.
We must take a care to port to pure Qt4 here. Current Tags Filters still to use Q3ListView. Code from Marcel is already pure

http://lxr.kde.org/source/extragear/graphics/digikam/digikam/tagfilterview.h#51

.
For options from Filter view pop-up menu, i recommend to use it as well and to change behavior later, because it require a lots of test to re-validate.

Gilles Caulier

Git commit 91a71c0e48780b572ea0c8320c96af6d1a9e8f90 by Gilles Caulier.
Committed on 16/02/2011 at 12:49.
Pushed by cgilles into branch 'development/2.0'.

Move Rating filter from statusbar to Tags Filter view from right sidebar.
As Rating is considerated as a Labels (like Pick or Color), it need to be moved
near Pick/Color Label filters.

Note that i plan to move all filters from status bar to right Sidebar and
rename "Tag Filters" as "Filters", and to add
2 buttons on status bar :
"Reset" to clean all active filters
"Settings" (or something like that) to switch on "Filters" panel from right
sidebar.

The advantage to use "Filters" panel from right side bar is to be able to host
more filters in the future.
Status bar is limited in space to host more settings. There are a lots of
whishes about this subject in bugzilla.

CCBUGS: 241847

M  +6    -32   digikam/albumiconviewfilter.cpp
M  +2    -5    digikam/albumiconviewfilter.h
M  +0    -6    digikam/digikamapp.cpp
M  +5    -5    digikam/digikamview.cpp
M  +18   -2    digikam/tagfiltersidebarwidget.cpp
M  +5    -2    digikam/tagfiltersidebarwidget.h
M  +1    -0    digikam/tags/colorlabelfilter.cpp
M  +1    -0    digikam/tags/picklabelfilter.cpp
M  +7    -7    libs/imageproperties/imagedescedittab.cpp
M  +12   -2    libs/models/imagefiltersettings.cpp
M  +3    -1    libs/models/imagefiltersettings.h

http://commits.kde.org/digikam/91a71c0e48780b572ea0c8320c96af6d1a9e8f90

Git commit 01ac5693959fba9a28f6be320572e66822db2e12 by Gilles Caulier.
Committed on 16/02/2011 at 16:34.
Pushed by cgilles into branch 'development/2.0'.

move search text filter to Tags Filter sidebar
CCBUGS: 201282
CCBUGS: 210576

M  +5    -19   digikam/albumiconviewfilter.cpp     
M  +1    -4    digikam/albumiconviewfilter.h     
M  +9    -7    digikam/digikamview.cpp     
M  +30   -6    digikam/tagfiltersidebarwidget.cpp     
M  +4    -0    digikam/tagfiltersidebarwidget.h     

http://commits.kde.org/digikam/01ac5693959fba9a28f6be320572e66822db2e12

Git commit 7302d22296928e69278da056b17afb37c9172269 by Gilles Caulier.
Committed on 16/02/2011 at 16:50.
Pushed by cgilles into branch 'development/2.0'.

move type mime filter to Tags Filter sidebar
CCBUGS: 201282
CCBUGS: 210576

M  +3    -1    NEWS     
M  +3    -11   digikam/albumiconviewfilter.cpp     
M  +0    -1    digikam/albumiconviewfilter.h     
M  +3    -3    digikam/digikamview.cpp     
M  +17   -0    digikam/tagfiltersidebarwidget.cpp     
M  +1    -1    digikam/tagfiltersidebarwidget.h     
M  +10   -0    libs/models/imagefiltersettings.cpp     
M  +2    -0    libs/models/imagefiltersettings.h     

http://commits.kde.org/digikam/7302d22296928e69278da056b17afb37c9172269

Git commit 75761c8459b880f23111e8bfc6061e2441e2d37a by Gilles Caulier.
Committed on 16/02/2011 at 17:24.
Pushed by cgilles into branch 'development/2.0'.

rename TagsFilter to Filters
Add 2 buttons on status bar to reset all filters and to pop-up filters view from right sidebar.
BUGS: 201282
BUGS: 210576

M  +28   -2    digikam/albumiconviewfilter.cpp     
M  +1    -0    digikam/albumiconviewfilter.h     
M  +11   -1    digikam/digikamview.cpp     
M  +2    -0    digikam/digikamview.h     
M  +5    -0    digikam/tagfiltersidebarwidget.cpp     
M  +2    -0    digikam/tagfiltersidebarwidget.h     

http://commits.kde.org/digikam/75761c8459b880f23111e8bfc6061e2441e2d37a

Gilles,

I like the fact that all filters are in the same tab now.
But what about putting this at the bottom of the main windows not on the right ?On the right we are information about the current selected picture.
On the left we have browsing.
On the bottom we would have the filters. 
It does not to be in the status bar, but as an horizontal pane  like the sidebars.


Concerning the green/red/grey icon for filters, thunderbird has a nice feature: when there is no solution for the current filter the whole area is framed in red. I think this would be better than the red icon in the status bar, because one does not necessarily notices this small red icon.

I can add a screenshot if you don't see what I mean.

Julien

Julien,

Thanks to review again my code.

The way to put all filter in sidebar is to be able to include new one without to be limited by view size.

In statusbar, i cannot see how we can add new filters without to bloat gui.

Also, how do you want to have a suitable view of tag filters from status bar. including it in a combobox as in Advanced search tool will be very limited solution, especially if tag view is huge. i tried this and forget this way.

The way to use an horizontal view to host filter will provide a large area (not only a simple status bar). Using sidebar instead, i can use a vertical scroll view which is more natural. I see Aperture using a similar way...

About status bar indicator, i agree that LED is too small. I like the thunderbird solution. It's very easy to implement. I will take a look

Gilles Caulier

Ok Gilles a vertical area is maybe more natural.

Maybe to clarify the difference between the filter tab and the other tabs, you could add a small space before the icon for the filter tab.

Julien

... or moving to the bottom of sidbar button list. i remember to see this somewhere. I need to search...

Gilles

Git commit 5192c6532c0d5be320ced32f9629de3e3d76a99e by Gilles Caulier.
Committed on 19/02/2011 at 22:19.
Pushed by cgilles into branch 'development/2.0'.

paint filter status from status with an hightlighted background color, as dolphin, kmail, or thunderbird
CCBUGS: 210576

M  +61   -8    digikam/albumiconviewfilter.cpp     
M  +3    -5    digikam/albumiconviewfilter.h     

http://commits.kde.org/digikam/5192c6532c0d5be320ced32f9629de3e3d76a99e