Bug 210521

Summary: icons for OS/X are not installed in their bundle
Product: [Developer tools] buildsystem Reporter: Jeremy Lainé <jeremy.laine>
Component: generalAssignee: Alexander Neundorf <neundorf>
Status: RESOLVED WORKSFORME    
Severity: normal Keywords: triaged
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Other   
Latest Commit: Version Fixed In:
Attachments: Fix location of icons for OS/X bundles

Description Jeremy Lainé 2009-10-14 11:33:00 UTC
Version:            (using KDE 4.3.2)
OS:                OS X
Installed from:    Compiled From Sources

I have recently started trying to get KDE in macports into shape and one thing I noticed is that applications built as bundles (*.app) for OS/X didn't have any icons.

Taking kteatime as an example, what is happening is that while the bundle is getting installed to:

/Applications/MacPorts/KDE4/kteatime.app

.. the icon is ending up in:

/opt/local/bin/kteatime.app/Contents/Resources/kteatime.icns

So I looked at KDE4Macros.cmake and found:

---------------
#            this doesn't seem to work for me - Use manual "install" instead
# TODO: test again with cmake 2.6 ?
#           SET_SOURCE_FILES_PROPERTIES(${CMAKE_CURRENT_BINARY_DIR}/${target}.icns PROPERTIES MACOSX_PACKAGE_LOCATION Resources)

install(FILES ${_outfilename}.icns DESTINATION ${BIN_INSTALL_DIR}/${target}.app/Contents/Resources/)
---------------

Well sure enough if I comment out the "install" line and restore the "set_source_files_properties", things work just fine.
Comment 1 Jeremy Lainé 2009-10-14 11:34:05 UTC
Created attachment 37574 [details]
Fix location of icons for OS/X bundles
Comment 3 Andrew Crouthamel 2018-09-24 01:57:20 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Andrew Crouthamel 2018-10-27 04:15:20 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!