| Summary: | Rename "Delete Selected" tool button | ||
|---|---|---|---|
| Product: | [Applications] kget | Reporter: | Michael Reiher <redm> |
| Component: | general | Assignee: | KGet authors <kget> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | mat69, nekkar, pfeiffer, skyphyr |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Michael Reiher
2009-10-08 21:37:39 UTC
Hey! We already have the "Remove finished transfers" (I think that was the string) in the context menu. "Delete selected" actually also deletes files when the transfer is not finished, but removed... Lukas PS: Maybe renaming to "Remove selected" would solve the confusion? BTW, what happens if you remove transfers that are still running? Will they keep on downloading or not? Oh, indeed it's in the menu... didn't know. The question is whether "Remove finished transfers" should be perhaps the primary remove option and thus be in the toolbar. I can only speak for myself of course, but I almost never remove manually selected downloads. However I regularly remove all finished downloads the have accumulated. I have no scientific usability data, but I'd not be surprised if that is a pretty common use case. You download files, and from time to time you remove the finished downloads. So I would put "Remove finished transfers" (or better "Remove Finished") in the toolbar and leave "Delete selected" (or "Remove Selected") to the context menu. Regarding PS: Yep, renaming "delete" to "remove" or "clear" (which IMHO would fit better. Also Firefox uses Clear in the download list IIRC) is definitely a good thing. "Delete" sounds just too dangerous and confusing :) SVN commit 1032907 by lappelhans: *Delete All Finished -> Clear All Finished *Delete selected -> Remove selected *Add Clear All Finished to toolbar BUG:209915 M +2 -2 mainwindow.cpp M +1 -0 ui/kgetui.rc WebSVN link: http://websvn.kde.org/?view=rev&revision=1032907 Hey! Hope with that commit everything is ok for you... @Carsten: Removing a still downloading transfer will remove it from the list, stop the download and delete all temporary files... Lukas Well, I'd use either "Remove" or "Clear" for both entries (as they do the same, just that one applies for all and the other for selected downloads). And the "All" is probably redundant (which would make the tool button text shorter) :) Other than that: Wow, that was fast! Thanks! :) SVN commit 1032932 by lappelhans: Clear -> Remove again CCBUG:209915 M +1 -1 mainwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1032932 Hehe :) Changed both to "Remove" now, left the all though... Lukas Cool. I'll shut up now :) Wouldn't it be better to have just one Remove button that expands to the two options: "Remove Selected" and "Remove finished" just like the start and stop buttons? I think it would be more rationale and the gui would remain "easy" as it was before :) Ah.. Also.. I've noticed that when you use the "Delete all finished", you have the expanded transfers (showing details) that contract automatically.. Feel free to merge the Actions to an expanding one... About extended details: Yeah, if you have details expanded and you do some stuff on the list, the chances are high that it gets corrupted... :/ Lukas @Dario I did the workaround where on every operation that changes the model (e.g. a remove and an insert) all elements are contracted. The method in KExtendibleItems (or what it is called) that only contracts the selected did not always work and thus resulted in the bug where you would have an extender with no item. @matthias: should be easier now to make any change to that code. If you take a look at it we have now everything moved from the delegate to the view. It should be easier to make a workaround for this, if we find it necessary :) *** Bug 173373 has been marked as a duplicate of this bug. *** |