Bug 209768

Summary: self-test nearly unreadable with dark color scheme
Product: [Applications] kleopatra Reporter: Milian Wolff <mail>
Component: generalAssignee: Marc Mutz <mutz>
Status: RESOLVED FIXED    
Severity: normal CC: aheinecke, kdepim-bugs
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Debian testing   
OS: Unspecified   
Latest Commit: http://commits.kde.org/kleopatra/9b7c6e0aff2e2cd99abbb1450a9f022ba4702f93 Version Fixed In:
Sentry Crash Report:
Attachments: screenshot showing bad colors under dark color scheme

Description Milian Wolff 2009-10-07 15:51:54 UTC 
Version:            (using KDE 4.3.1)
Installed from:    Debian testing/unstable Packages

the colorization in the kleopatra self-test is nearly unreadable under dark KDE color schemes, because I bet the background colors are hard-coded. See attached screenshot.

To fix this problem, just use KColorScheme and query it for applicable background colors:

KColorScheme scheme(palette().currentColorGroup());
scheme.background(KColorScheme::NegativeText);
Comment 1 Milian Wolff 2009-10-07 15:52:51 UTC 
Created attachment 37424 [details]
screenshot showing bad colors under dark color scheme
Comment 2 Andre Heinecke 2013-05-08 07:52:34 UTC 
I would say the proper fix here would be to force the font color to be black. As the colors red / green / yellow are used to contain information I don't think they should be changed depending on the colorscheme and rather think that the problem is the changing foreground / text color.
Comment 3 Milian Wolff 2013-06-05 15:36:21 UTC 
The color scheme has the notion of negative, neutral and positive colors.  Instead of forcing a font color you should use those, thereby producing a visually cohesive image between KDE applications.
Comment 4 Andre Heinecke 2016-03-23 09:36:56 UTC 
Git commit 9b7c6e0aff2e2cd99abbb1450a9f022ba4702f93 by Andre Heinecke.
Committed on 23/03/2016 at 09:34.
Pushed by aheinecke into branch 'Applications/16.04'.

Use KColorScheme for selftest colors

M  +6    -3    src/dialogs/selftestdialog.cpp

http://commits.kde.org/kleopatra/9b7c6e0aff2e2cd99abbb1450a9f022ba4702f93