Bug 209633

Summary:	[PATCH] iTunes database importer hangs
Product:	[Applications] amarok	Reporter:	Jan Gosmann <jan>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jan, the.slaa
Priority:	NOR
Version:	2.3-GIT
Target Milestone:	---
Platform:	Compiled Sources
OS:	Other
Latest Commit:		Version Fixed In:	2.3.1
Attachments:	Patch for iTunes database importer.

Description Jan Gosmann 2009-10-06 14:55:09 UTC

Version:           2.2 (using KDE 4.2.4)
Compiler:          i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5646) 
OS:                OS X
Installed from:    Compiled From Sources

When using the iTunes database importer, it hangs (in an endless loop I suppose) after reading all tracks from the XML file. This is probably, because in my iTunes Database XML file additional data about playlists follows the track data.

I was able to solve the problem for me with a little code change (patch attached) by adding another end condition to one of the loops for reading the file.

Comment 1 Jan Gosmann 2009-10-06 14:56:19 UTC

Created attachment 37404 [details]
Patch for iTunes database importer.

Comment 2 Myriam Schweingruber 2009-10-06 16:33:47 UTC

*** Bug 209576 has been marked as a duplicate of this bug. ***

Comment 3 Mark Kretschmann 2009-11-04 10:58:24 UTC

Jan, could you please send us a Merge Request on Gitorious instead? This
makes it much easier for us to keep track of patches, and it allows you to
refine the patch further if there are problems with it.

Please see here:

http://gitorious.org/amarok/amarok/merge_requests

Comment 4 Jan Gosmann 2009-11-04 11:20:09 UTC

I did not worked that much with git until now. But I will try to find out how to do this (a bit more training in the usage of could be useful). However this might take some time, because I have to do a lot other stuff currently.

Comment 5 Jan Gosmann 2009-11-09 13:44:17 UTC

Ok, I figured out how to do this git stuff and created a merge request: http://gitorious.org/amarok/amarok/merge_requests/2042

Comment 6 Myriam Schweingruber 2009-11-16 23:05:25 UTC

Jan, could you please add the description asked for in your merge request? Thank you.

Comment 7 Jan Gosmann 2009-11-16 23:36:33 UTC

I will add the description as soon as I find the time to do so. This might take some weeks, because I have to do very much stuff for the university and some other stuff which has a higher priority to me.

Comment 8 Mikko C. 2009-11-28 14:24:34 UTC

set version

Comment 9 Myriam Schweingruber 2009-11-28 16:16:49 UTC

A patch would rather be against current git I think...

Comment 10 Myriam Schweingruber 2010-01-25 00:22:21 UTC

Jan, if you want your patch to be in Amarok 2.2.3, you should react soon, feature and string freeze will be on February 9th

Comment 11 Jan Gosmann 2010-01-25 08:59:13 UTC

What do you want me to do exactly?
I already created a merge request on gitorious.org: http://gitorious.org/amarok/amarok/merge_requests/2042
It also has an elaborate description of the bug and the fix. As far as I see (from the last comment) someone of the Amarok team has to decide whether to include the patch.

Comment 12 Myriam Schweingruber 2010-01-25 13:12:43 UTC

I was checking on unhandled patches, just to make sure those are reacted upon, thanks for your feeback.

Comment 13 Myriam Schweingruber 2010-06-07 23:42:41 UTC

This was merged 2 months ago.