Bug 209454

Summary:	"Trash successfully emptied" notification has neither a message nor an icon defined
Product:	[Frameworks and Libraries] kio	Reporter:	markuss <kamikazow>
Component:	trash	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andresbajotierra, asraniel, finex, null, peter.penz19
Priority:	NOR	Keywords:	junior-jobs
Version:	4.4
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Screenshot Screenshot 2 Screenshot of 4.6rc2

Description markuss 2009-10-04 22:00:02 UTC

Version:            (using KDE 4.3.1)

In kdebase/workspace/plasma/generic/applets/systemtray/core/extendertask.cpp there is no icon defined for "Recently Completed Job" message. I'm not sure how to add that.

I suggest using simply "dialog-information" as icon.

Screenshot attached.

Comment 1 markuss 2009-10-04 22:00:32 UTC

Created attachment 37366 [details]
Screenshot

Comment 2 Dario Andres 2009-10-06 02:02:20 UTC

This is fixed for me here using:

Qt: 4.6.0 (Qt git branch 4.6 commit f3d15516572394b6bcd44a89dd66516fa4eba56e
        Date:   Fri Sep 25 10:21:23 2009 +1000)
KDE: 4.3.70 (KDE 4.3.70 (KDE 4.4 >= 20091002))
kdelibs svn rev. 1030916 / kdebase svn rev. 1030916
on ArchLinux i686 - Kernel 2.6.30.6

@FiNeX: can you double check this ?
Thanks

Comment 3 markuss 2009-10-11 14:40:43 UTC

Well, if it has an icon in trunk, the fix should be backported to 4.3

Comment 4 Dario Andres 2009-11-01 01:05:11 UTC

I just checked this on an updated 4.3branch build and it has the icon too, but I can't really tell when it was fixed...
- Can you check this on KDE4.3.2/4.3.3 ?
Thanks

Comment 5 markuss 2009-11-02 13:16:49 UTC

Created attachment 38024 [details]
Screenshot 2

Weird. I just emptied the trash and now the upper message has an icon, but not the lower one (see new screenshot).
Considering that the source code file in question hasn't been really altered in the past few months (in the 4.3 branch at least), I suspect that the icon fetching method as a whole is kinda broken.
The file log in trunk has no message indicating that icon handling has been altered.

Comment 6 markuss 2009-11-02 13:21:08 UTC

An idea just popped into my mind: Maybe it's not Plasma's fault, but of the application that requests Plasma to show the progress bars.

At least in both of my cases Dolphin was involved. I've added Dolphin's maintainer Peter Penz as CC. Maybe he can have a look into it.

PS: Comment #5 -- I use KDE 4.3.2 now.

Comment 7 markuss 2010-03-07 21:02:56 UTC

At least for the "Trash emptied" notification it's still valid.
Changing the subject. "Screenshot 2" also applies for SC 4.4.1

Comment 8 markuss 2011-01-06 17:26:38 UTC

Created attachment 55650 [details]
Screenshot of 4.6rc2

Still the same in 4.6rc2 :-/

Comment 9 Unknown 2012-01-12 09:11:54 UTC

*** Bug 265633 has been marked as a duplicate of this bug. ***

Comment 10 markuss 2012-10-17 23:14:54 UTC

I no longer even get notifications for that event (since 4.7 or so), so I guess it's kinda fixed.
I'm closing this bug. Reopen if one sees that bug again.