Bug 209123

Summary:	Display line edit should be a combo box
Product:	[Applications] kaddressbook	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	VERIFIED FIXED
Severity:	normal	CC:	tokoe
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Sabine Faure 2009-10-01 18:31:38 UTC

Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch Kontact and go to KAB
- Select an address book and create a contact (Name and Surname)
- the 'Display' line edit gets filled automatically as you enter the 'Name'
- click in the 'Display' line edit to modify its entry.

Nothing happens. It is impossible to type in the line edit. 
So I think it is misleading to have a line edit there. Maybe there should be a combo box instead, given that if you right click on the 'Display' line edit a context menu appears.

Also it was not clear to me that the 'Display' functionality would not only be used for display in KAB but also when sorting or printing. 
So maybe there could be a title to the context menu or a tool tip saying that this field will be used in all those cases: 'The selected option will be used for displaying, sorting and printing the contact'

Before realizing this I assumed that sorting and printing would been made according to surnames.
But that would narrow possibilities a lot.


Trunk, Svn Rev 1030016

Comment 1 Tobias Koenig 2009-10-02 11:11:02 UTC

If you select 'Custom' in the RMB menu, you can edit the name, so having
a lineedit here makes sense.

Regarding the meaning of Display Name, the real bug is, that there is no
consistent usage of the display name currently. Actually it shouldn't be used
for sorting only for showing. However as there might be no display name available
handling it in a consitent way is difficult

Comment 2 Sabine Faure 2009-10-02 22:43:48 UTC

Just to make sure you understood my point of view, I was thinking about an editable combo box for the 'Display' feature when selecting 'Custom' and about a read only combo box otherwise showing the other options. So that it's obvious for the user that he can select a different option or type a custom name in as well.

I am confused now. Why not set the 'full name' radio button as default to always have a Display name?

You seem to agree that there is a bug with the fact that the display name is not used when printing, right? So I am retitling this bug accordingly so that this issue gets fixed.

Trunk, Svn Rev 1030528

Comment 3 Tobias Koenig 2009-11-04 20:13:47 UTC

SVN commit 1044847 by tokoe:

Replace display name lineedit by a combobox

BUG: 209123


 M  +105 -88   displaynameeditwidget.cpp  
 M  +11 -7     displaynameeditwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1044847

Comment 4 Sabine Faure 2009-11-05 18:36:08 UTC

It is corrected now.

There is now a combo box instead of the line edit for the Display name.

Trunk, Svn Rev 1045165