| Summary: | More options when converting raws | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Me <linuxguy123> |
| Component: | Plugin-DImg-RAW | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, languitar, linuxguy123 |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 5.1.0 | |
| Sentry Crash Report: | |||
| Attachments: |
Editor screenshot.
setup editor page Raw Import tool in action (1) Raw Import tool in action (2) Raw Import tool in action (3) digiKam First Run : Raw File Handling Settings digiKam Batch Queue Manager Converting RAW file to PNG plus other actions |
||
|
Description
Me
2009-09-30 17:11:30 UTC
This should have been tagged as a wish, not a bug. Sorry. I should also add that I develop software and I might be willing to implement this functionality myself if I got a little guidance from the development team in terms of how they would like it done. It would be really helpful if someone drew laid out the gui how they would like it. digiKam don't use ufraw to process RAW files, in single or batch mode. We use libraw with libkdcraw... If something must be improved with digiKam, it must be done in libraw or/and libkdcraw... More info : www.libraw.org Gilles Caulier Sorry. For some reason I though digikam was using ufraw as its converter. I didn't mean any slight to digikam by my mistake. Having said that, most of the features I am asking for, if not all, map directly to components of the dcraw like API that libraw provides and implementing them should be fairly straightforward except for the fact that a GUI must be designed so that the user can access the features. If digikam were using ufraw as the converter, these features could have been made usable to the end user via a command line options text box. The ease of which this could have been done is what prompted me to ask for this enhancement like I did. So... could "we" implement a GUI that would allow digikam to make libraw to do some of the things I requested ? Ie do you see the workflow case for what I am asking for ? Thanks No, we don't use ufraw. It's not a library. libraw is fine for digiKam. A lots of new features are available in current code, but not yet used in libkdcraw. Note libraw code is in libkdcraw core, for simplicity... Look there : http://websvn.kde.org/trunk/KDE/kdegraphics/libs/libkdcraw/ digiKam use libkdcraw interface which provide QT/KDE access to libraw and some widgets. libkdcraw is used everywhere in digiKam and kipiplugins. Mst relevant code are there : Raw image loader for digiKam core (DImg class) : http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/dimg/loaders/rawloader.cpp?view=markup Raw decoding settings for digiKam : http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/dimg/drawdecoding.h?view=markup digiKam editor raw import tool : http://websvn.kde.org/trunk/extragear/graphics/digikam/utilities/imageeditor/rawimport/ kipi-plugins raw converter : http://websvn.kde.org/trunk/extragear/graphics/kipi-plugins/rawconverter/ Gilles I just reread my original post and did some thinking. I feel that the original feature requests are reasonable, ie they are what an advanced user would want to do. Including: 1) the ability to use a raw converter utility of some sort (ufraw, raw studio or something else) to create a curve file and then apply it to the batch conversion that will be done. 2) having the conversion process create conversion id file like ufraw does so that one can see what was done to generate an image and repeat it if desired. So the question becomes how hard is this to do with the libraw libraries. In order to do item #1, digikam would need to build in a raw generator/editor tool similar to ufraw or raw studio. Or it could use the output of a tool like those as the input to its raw conversion process. I think item #2 is even more work to do. Basically we are talking about building a raw studio or ufraw application into digikam. Do we want to re-invent the wheel ? What if digikam has a preferences option that allowed the user to a) use the built in libraw tools as they are now or b) allowed the user to use ufraw (ufraw-batch). This is what the grip application does for specifying the ripper and enocders. See Grip->Config->Rip->Ripper and Grip->Config->Encode. I know its a bit of work to implement but it would allow the user a lot more functionality. Thinking ahead, the Windows users are really going to want this sort of stuff because they have access to the OEM raw conversion tool (ie DPP from Canon) as well as tools from Adobe and others. To limit digikam to just its built in raw converter without being able to use and manage curve files and generate conversion id files will severely limit its desirability for advanced raw users. The more I think about this the more I think the end user needs to be able to specify which raw converter they want to use and be able to set it up to use more or all of its features. Comments ? ... Do you hae tested RAW Import tool for digiKam image editor ? Go to setup/editor and set on right option... After that, look what is missing in import tool settings. For batch conversion, kipi tool will become obsolete, because in digiKam a new Batch Queue MAnager is implemented, but RAW Import tool is not yet added (RAW conversion is done using default RAW conversion settings as well. I recommend to check out code from trunk and test it, instead to use 0.10.0 Gilles Caulier "... Do you hae tested RAW Import tool for digiKam image editor ? Go to setup/editor and set on right option..." Where do I find this ? $ rpm -q digikam digikam-0.10.0-2.fc11.i586 "After that, look what is missing in import tool settings." The only things I see related to raw settings are: Gallery View -> Settings-> Raw Decoding (libraw0.7.2) Gallery View-> Settings -> Kipi Plugins - shows RawConverter is enabled. I don't see anything in the image editor. "For batch conversion, kipi tool will become obsolete, because in digiKam a new Batch Queue MAnager is implemented, but RAW Import tool is not yet added (RAW conversion is done using default RAW conversion settings as well." Maybe I could write a ufraw kipi tool ? "I recommend to check out code from trunk and test it, instead to use 0.10.0" I might do that. Is that where this new functionality is ? >"... Do you hae tested RAW Import tool for digiKam image editor ? Go to >setup/editor and set on right option..." >Where do I find this ? Setup, editor page, "Use Raw import tool" option... >"After that, look what is missing in import tool settings." >The only things I see related to raw settings are: >Gallery View -> Settings-> Raw Decoding (libraw0.7.2) >Gallery View-> Settings -> Kipi Plugins - shows RawConverter is enabled. >I don't see anything in the image editor. really. check again... >"For batch conversion, kipi tool will become obsolete, because in digiKam a new >Batch Queue MAnager is implemented, but RAW Import tool is not yet added (RAW >conversion is done using default RAW conversion settings as well." >Maybe I could write a ufraw kipi tool ? Definitively... NO >"I recommend to check out code from trunk and test it, instead to use 0.10.0" I might do that. Is that where this new functionality is ? http://websvn.kde.org/trunk/extragear/graphics/digikam/NEWS?revision=1030132&view=markup Gilles (In reply to comment #8) > >"... Do you hae tested RAW Import tool for digiKam image editor ? Go to > >setup/editor and set on right option..." > > >Where do I find this ? > > Setup, editor page, "Use Raw import tool" option... I also had to ask to find this option. Maybe we should think about making this option more prominent in the gui...? In 1.0.0, there is a First Run Assistant where the question is clearly asked to enable or not this option... Gilles Caulier Created attachment 37310 [details]
Editor screenshot.
I don't see a "Setup" menu item anywhere.
Created attachment 37313 [details]
setup editor page
use "Settings/Configure digiKam" menu entry
Created attachment 37314 [details]
Raw Import tool in action (1)
Created attachment 37315 [details]
Raw Import tool in action (2)
Created attachment 37316 [details]
Raw Import tool in action (3)
OK, found it. For future reference the way I would have told someone to find that is digikam-> Settings-> configure Digikam -> Image Editor -> Raw... I'll have a look at what is there in depth tomorrow and compare it to my list above. It looks like a good start. It looks really good actually. I suggest that this functionality option should be added/moved to the Raw area of the configuration list rather than remain in the editor area. While its true that the functionality is used in the editor, its also used for batch conversions from the album view area and I think users would more likely associate it with a raw attribute than an editor attribute. Just my $0.02. >I suggest that this functionality option should be added/moved to the Raw area >of the configuration list rather than remain in the editor area. Raw Import tool is for Editor and editor only... This si why it's in Editor section >While its true that the functionality is used in the editor, its also used for >batch conversions from the album view area and RAW section is all default demosaicing settings used when this option is not enabled in editor AND for batch RAW conversion in Batch Queue Manager. In other word, In BQM, we need to find RAW Import setting as base tool... It still TODO. Gilles Caulier Created attachment 37318 [details]
digiKam First Run : Raw File Handling Settings
Created attachment 37319 [details]
digiKam Batch Queue Manager Converting RAW file to PNG plus other actions
The first start wizard is only shown to people that do a fresh install of digiKam, all the others will never see this screen. Is there a reason why we don't enable it by default? Sure people with an existing config will still not have the feature enabled and have to search for this option. I suppose the wizard uses the raw import tool option as a default, right? But still my question is: Why not make it default and completely remove this option? What is the benefit of NOT using the tool? The first approach of digiKam is to be simple. This is the goal of LightZone. You click on RAW file and all is done automatically. RAW handling is the same than JPEG. In fact, the world photography must be done like this. A Lots of photograph don't care, don't know, don't want to understand what's RAW files, but know that RAW is better than JPEG from color depth viewpoints. Users only know advantages, not disadvantage. So, the default option is to open and let's digiKam/Libkdcraw/libraw handle raw as well, without to ask any questions about demosaicing. This is not my case of course, and for pro users sure... I only edit RAW files with in-deep settings adjustments. Of course, auto-gamma/WB with raw must be improved. This is the job of libraw, not to digiKam libkdcraw. This is why, i update frequently libraw source code in libkdcraw... The current way of RAW in photography is really a shame. I hope in the future that JPEG-XR will change that. Yes, i know it's M$ stuff, but all is ready to be included in camera firmware. http://en.wikipedia.org/wiki/JPEG_XR After that, there is no reason to support RAW format in camera anymore. Gilles Caulier I'll provide further comment after I have done some work in 1.0.0 beta 5. I am building it now. Any fresh comments since comment #22 ??? Gilles Caulier We need a fresh feedback here using last digiKam 4.2.0. Gilles Caulier New digiKam 4.11.0 is available : https://www.digikam.org/node/740 Can you reproduce the problem with this release ? Gilles Caulier With digiKam 5.0.0, this problem is not reproducible. I close this file now. Don't hesitate to re-open if necessary. Gilles Caulier |