Bug 208410

Summary:	Patch: Allow custom tags per image
Product:	[Applications] digikam	Reporter:	Johannes Wienke <languitar>
Component:	Plugin-WebService-Flickr	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	caulier.gilles, p.edelman
Priority:	NOR
Version:	5.6.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Unspecified
Latest Commit:		Version Fixed In:	0.8.0
Attachments:	custom tags per image custom tags per image

Description Johannes Wienke 2009-09-24 17:25:51 UTC

Version:           rev 1027625 (using KDE 4.3.1)
Installed from:    Ubuntu Packages

I've created a patch that allows adding custom tags for each image that's going to be uploaded.

It's implemented in a same (somewhat hacky) way as the selection of privacies per image. If there are more things to edit directly in the image list moving to a QTreeView reflecting a proper model would definitely be advisable.

I'm not sure if this somehow affects zooomr or 23 functionality as I don't have an account there.

Comment 1 Johannes Wienke 2009-09-24 17:26:42 UTC

Created attachment 37157 [details]
custom tags per image

Patch as described above

Comment 2 caulier.gilles 2009-09-24 19:41:26 UTC

Pieter,

Do you have time to review this patch ? Thanks in advance...

Gilles Caulier

Comment 3 Pieter Edelman 2009-09-24 20:44:59 UTC

I'll put it on my list, I will review it soon and try to figure out the implications for Zooomr and 23.

I agree that using the Delegate/View model would be much better, but that will have to wait.

Comment 4 Johannes Wienke 2009-09-25 14:41:03 UTC

Created attachment 37170 [details]
custom tags per image

Fixed a segfault caused by my previous patch

Comment 5 Pieter Edelman 2009-10-04 14:57:16 UTC

SVN commit 1031227 by pieteredelman:

Patch by Johannes Wienke to allow for setting extra tags per image in the Flickr/23/Zooomr export plugin.

CCBUGS: 208410

 M  +21 -8     flickrlist.cpp  
 M  +20 -4     flickrlist.h  
 M  +189 -126  flickrwidget.cpp  
 M  +31 -25    flickrwidget.h  
 M  +86 -59    flickrwindow.cpp  
 M  +4 -2      flickrwindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1031227

Comment 6 Pieter Edelman 2009-10-04 15:07:05 UTC

I took the liberty of reworking the export options tab, because both this tab and the file list became quite cluttered with all the extra options that most users probably don't care about.
Therefore, I grouped together the account and photoset, all the tag options, all the publication options, and the resizing options in their own boxes. For the tags and for the publication options, advanced options can be set (for the tags: strip spaces, extra tags for all photos, extra tags for individual photos; for the publication options: content type and safety level).
http://farm3.static.flickr.com/2566/3979359351_394f8dc514_o.jpg
http://farm4.static.flickr.com/3433/3979359581_fa213824a0_o.jpg

Also, I changed the option when specifying extra global or per image tags to use spaces, and the "Remove spaces" option applies to all specified tags, not just the application tags.

Comment 7 caulier.gilles 2009-10-04 15:14:43 UTC

Pieter,

Please feel Bugzilla file closed title and number to NEWS file to have a complete list of bugs fixed for the release. NEWS file is used later when release is published to internet.

Thanks in advance

Gilles

Comment 8 Pieter Edelman 2009-10-04 15:22:43 UTC

Ok, I'll try to remember :P