Summary: | JJ: Randomize playlist with Ctrl+H | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Andy Kelley <superjoe30> |
Component: | Shortcuts | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | chealer, harshinlko, k.dummann, matej |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 2.4-GIT | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/amarok/62ce5195cfe30b78ec3e234f1d1f5dbed7534a4b | Version Fixed In: | 2.8 |
Attachments: | Added a shortcut button for shuffle with default shortcut as Ctrl + H |
Description
Andy Kelley
2009-09-21 11:22:28 UTC
playlist randomization will be available in 2.2 with the new playlist sorting. This wish has been granted.This report should be removed. (In reply to comment #2) > This wish has been granted.This report should be removed. So sorry, please disregard this message, there was a misunderstanding with the Google Code-In student. Shouldn't be hard. Note to implementors: set playlist sorting to Shuffle on Ctrl+H. I am interested in solving this bug. Someone please guide me and tell me how does amarok handle shortcuts. Should I clear all sorting levels or just add shuffle level to current sorting levels on pressing Ctrl + H ? (In reply to comment #6) > Should I clear all sorting levels or just add shuffle level to current > sorting levels on pressing Ctrl + H ? I think clearing them first makes more sense. Created attachment 76869 [details]
Added a shortcut button for shuffle with default shortcut as Ctrl + H
Created a slot shuffleTrack in mainWindow which is triggered on pressing Ctrl + H
Comment on attachment 76869 [details] Added a shortcut button for shuffle with default shortcut as Ctrl + H Please submit patches to http://reviewboard.kde.org/ instead. Git commit 62ce5195cfe30b78ec3e234f1d1f5dbed7534a4b by Matěj Laitl, on behalf of Harsh Gupta. Committed on 10/02/2013 at 14:59. Pushed by laitl into branch 'master'. Add Ctrl+H shortcut to ranzomize playlist FEATURES: * Added Ctrl+H shortcut to randomize playlist, patch by Harsh Gupta. @Harsh, I've fixed position of the ChangeLog entry and made one minor code-style tweak. CCMAIL: Harsh Gupta <harshinlko@gmail.com> FIXED-IN: 2.8 REVIEW: 108716 M +1 -0 ChangeLog M +14 -0 src/MainWindow.cpp M +1 -0 src/MainWindow.h http://commits.kde.org/amarok/62ce5195cfe30b78ec3e234f1d1f5dbed7534a4b Trying to use Ctrl+H (or any shortcut I define) crashes my Amarok 2.8.0 on Debian testing. I reported this in Debian's #725895. (In reply to comment #11) > Trying to use Ctrl+H (or any shortcut I define) crashes my Amarok 2.8.0 on > Debian testing. I reported this in Debian's #725895. This is a known problem on 2.8 that was fixed right away after it was released, unfortunately it was not caught before: bug 323614. You may tell Debian to use this patch: http://commits.kde.org/amarok/2f42e4687d5dd277d0e39f012c49496f6e9631c8 Thank you Matěj. I've tagged Debian's ticket appropriately. |