Summary: | okular does not handle escaped URL correctly | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | Mary Ellen Foster <mefoster> |
Component: | general | Assignee: | Okular developers <okular-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | arequipeno, finex, mail, mhlavink, oliver.henshaw, rdieter |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Mary Ellen Foster
2009-09-15 15:19:44 UTC
from the shell okular "http://homepages.inf.ed.ac.uk/mef/file%20with%20spaces.pdf" <- works okular "http://homepages.inf.ed.ac.uk/mef/file with spaces.pdf" <- works What's the problem? Cannot reproduce here (trunk): I've tried to open that file with okular from firefox and konqueror and it always worked. Which version of firefox did you used? Maybe it could an old firefox version which incorrectly call okular. The problem is what happens with downloaded files through Firefox. If I actually try to open that link in Firefox -- not just do "okular http://whatever" -- then, according to ps, the actual command line that's executed is: okular file:///tmp/file%20with%20spaces.pdf -caption The error message that I get in Okular is then "Cannot open file:///tmp/file%2520with%2520spaces.pdf" In other words, when the file:// URL is sent to Okular in this way, the percent signs get double-escaped and the file can't be opened. I can confirm this bug in okular 0.9.1. kde 4.3.1 (In reply to comment #1) > from the shell > okular "http://homepages.inf.ed.ac.uk/mef/file%20with%20spaces.pdf" <- works > okular "http://homepages.inf.ed.ac.uk/mef/file with spaces.pdf" <- works > > What's the problem? both of them work for me too what does not work: wget "http://homepages.inf.ed.ac.uk/mef/file%20with%20spaces.pdf" okular "file://`pwd`/file%20with%20spaces.pdf" (kwrite "file://`pwd`/file%20with%20spaces.pdf" works) How is this resolved? What information are you waiting for? I've found the problem, just need Pino to be back as it seems he introduced what is causing the problem to fix another problem. confirmed, anxiously waiting for pino magic. SVN commit 1032944 by pino: when we remove the file:/ from the argument, do the precent-encoding removal to avoid being percent-encoded more than needed based on a patch by Albert, slightly changed + unit test by me BUG: 207461 M +5 -0 shell/shell.cpp M +13 -0 tests/shelltest.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1032944 SVN commit 1032945 by pino: when we remove the file:/ from the argument, do the precent-encoding removal to avoid being percent-encoded more than needed based on a patch by Albert, slightly changed by me will be in kde 4.3.3 CCBUG: 207461 M +5 -0 shell.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1032945 |