| Summary: | Replace current renaming in AlbumUI with AdvancedRename utility | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Andi Clemens <andi.clemens> |
| Component: | Albums-MainView | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, pietras.sp |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 1.0.0 | |
| Sentry Crash Report: | |||
| Attachments: |
ManualRenameDialog patch
new version against trunk 3rd update 4th update patch against new modifier code threaded version tool was renamed, sync with trunk |
||
|
Description
Andi Clemens
2009-09-11 10:59:04 UTC
Created attachment 36864 [details]
ManualRenameDialog patch
This patch will enable the ManualRenameDialog for AlbumUI
Andi, I'm agree. Thsi feature is very important ! Do you use DIO method from digiKam core, to rename file, or kio_file process ? Gilles DIO (actually I just call the old rename method: ImageViewUtilities::rename()), I only added a second parameter 'newName' to the method. Created attachment 36873 [details]
new version against trunk
New version of the patch, since trunk changed the way parsing is done.
Please note that you need to disable the building of tests at the moment, because ManualRename will not link against digikamcore anymore (I still don't understand why).
Created attachment 36904 [details]
3rd update
update against trunk
Created attachment 36916 [details]
4th update
sync with trunk, a lot changed in there so patch needs some love :)
No new features so far, still the old problem with slow renaming.
I just played with renaming in AlbumUI again. When I rename 88 images with this patch, I get 83 kio_digikamalbums slaves that are not closed as long as digiKam is running. Something is going terribly wrong here. Do I need to do renaming in a different way then by just calling DIO::move()? DIO::rename I mean of course Just realized something else: I also have 64 kio_file slaves open, and they don't close even digiKam is shut down. I can only kill them by hand. Calling DIO::rename() multiple times doesn't seem to be the right way. I know there is a move() method for multiple files, the problem is that it has a single target, so it is not suitable for renaming tasks. Created attachment 36970 [details]
patch against new modifier code
sync with trunk
Looking in your patch, how do you process files renaming in background ? Why not to use a separate thread running KDE::rename() trough a queued list of items to process one by one ? Gilles Oh, never had a look at KDE::rename. I will check this later. Image Editor already use it. Look there : http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor /editorwindow.cpp#1762 Gilles Created attachment 36998 [details]
threaded version
I added a thread but I'm not sure if I use it correctly, never done this before.
Could you please take a look at
RenameThread() and its interaction with ImageViewUtilities()?
Andi
Created attachment 37041 [details]
tool was renamed, sync with trunk
One remark. I would be nice if the same renamame dialog would be used during import from camera. I can remember that in 0.9 the rename during import was not able to handle my simple pattern so I had to do this after import with normal digikam rename. The new renaming tool is used in CameraUI (import) and BQM (Batch Queue Manager) for months :-) It was not used in the main application due to threading problems (that in some way still exist, but at least renaming is working now). Since I committed everything (and only some minor tweaks have to be made), I will close this wish now. Andi, Let's me hear when Renaming tool will be ready to use in Album GUI, to prepare 1.0.0-beta5 tarball. Gilles |