Bug 206995

Summary: GPSCorrelator: "Remove" removes from all and does not update digikam-database
Product: [Applications] digikam Reporter: Michael G. Hansen <mike>
Component: Geolocation-CorrelatorAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 0.7.0
Sentry Crash Report:
Attachments: Fix "Remove gpsinfo", against r1022044

Description Michael G. Hansen 2009-09-10 20:32:52 UTC 
Version:           0.6+svn (using KDE 4.3.0)
OS:                Linux
Installed from:    Debian testing/unstable Packages

- select a few photos in the GPSCorrelator and hit "Remove"->all photos are marked as "Deleted".
  Fixed: Missed detection of whether items were actually selected.

- Hit "Apply": Coordinates are not shown in the exif information any more, but when are still stored in the digikam-database
  Fixed: wrong tags used when calling delAttributes, should have been "gpslocation". As far as I can tell, the tag name has always been "gpslocation", "delAttributes" was introduced here:
http://websvn.kde.org/?view=rev&revision=829840

Miscellaneous fixes:
- disable drag-and-drop in imageslist in gpscorrelator and tracklisteditor
- save directory of last gpx-file in gpscorrelator used in "Load gpx" dialog and reuse it on next "Load gpx"
Comment 1 Michael G. Hansen 2009-09-10 20:34:24 UTC 
Created attachment 36848 [details]
Fix "Remove gpsinfo", against r1022044
Comment 2 caulier.gilles 2009-09-11 16:49:03 UTC 
Why i can see this fix in your patch :

Index: advancedslideshow/maindialog.cpp
===================================================================
--- advancedslideshow/maindialog.cpp	(revision 1022044)
+++ advancedslideshow/maindialog.cpp	(working copy)
@@ -460,10 +460,8 @@
         addItems(urlList);
     }
 
-    m_ImagesFilesListBox->listView()->setDragEnabled(customize);
-    m_ImagesFilesListBox->listView()->setAcceptDrops(customize);
-    m_ImagesFilesListBox->listView()->setDropIndicatorShown(customize);
     m_ImagesFilesListBox->enableControlButtons(customize);
+    m_ImagesFilesListBox->enableDragAndDrop(customize);
 }

This is not relevant of GPSSync...

Gilles
Comment 3 caulier.gilles 2009-09-11 16:53:41 UTC 
nevermind. this fix is ok... Sorry

Gilles
Comment 4 caulier.gilles 2009-09-11 16:59:51 UTC 
SVN commit 1022349 by cgilles:

apply patch #36848 from Michael G.Hansen to fix several issues in GPSSync kipi-plugins 
BUGS: 206995


 M  +1 -3      advancedslideshow/maindialog.cpp  
 M  +20 -8     common/libkipiplugins/imageslist.cpp  
 M  +4 -0      common/libkipiplugins/imageslist.h  
 M  +8 -2      gpssync/gpslistviewitem.cpp  
 M  +43 -46    gpssync/gpssyncdialog.cpp  
 M  +3 -3      gpssync/gpssyncdialog.h  
 M  +1 -0      gpssync/gpstracklisteditdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022349