Bug 206714

Summary:	Can not select multiple images in list [patch]
Product:	[Applications] digikam	Reporter:	Michael G. Hansen <mike>
Component:	Plugin-Generic-GeolocationEdit	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andi.clemens
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:	0.7.0
Sentry Crash Report:
Attachments:	Add extended selections to ImagesList, patch against r1021090

Description Michael G. Hansen 2009-09-08 07:27:17 UTC

Version:           0.6 (using KDE 4.3.0)
OS:                Linux
Installed from:    Debian testing/unstable Packages

In 0.5, the images list in the GPS-correlator allowed me to select multiple images at a time and edit their coordinates at once, but in 0.6 this is no longer possible.

The attached patch changes the new ImagesList code to allow QAbstractItemView::ExtendedSelection style selections. The code has been tested with the AdvancedSlideshow and the GPS-correlator. I could not test the various export-plugins because I do not have accounts for the corresponding services.

A related note: When the control buttons are disabled, drag and drop in the ImagesList is still available, wouldn't it make sense to disable it at the same time? Only AdvancedSlideShow disables drag and drop explicitly.

Comment 1 Michael G. Hansen 2009-09-08 07:28:01 UTC

Created attachment 36784 [details]
Add extended selections to ImagesList, patch against r1021090

Comment 2 caulier.gilles 2009-09-08 08:12:08 UTC

Andy,

This patch is for myou has it touch your code in KipiPlugins::ImageList class...

Gilles Caulier

Comment 3 Andi Clemens 2009-09-08 10:57:00 UTC

I will take a look at it soon...

Michael,
thanks for the patch, I had totally forgotten to implement multiple selection again :) I disabled it temporarily because of the drag&drop features I implemented, but I actually wanted to bring back extended selection.

Comment 4 Andi Clemens 2009-09-08 11:36:42 UTC

SVN commit 1021134 by aclemens:

Apply patch from Michael G. Hansen: enable extended selection in
ImagesList widget.

BUG:206714

 M  +24 -25    imageslist.cpp  
 M  +2 -2      imageslist.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1021134

Comment 5 Andi Clemens 2009-09-08 11:40:53 UTC

About the TODO: Right now the idea is that the plugin that uses the ImagesList has to re-implement the load and save slots. The widget will become more generic in the future, not only for images, so that it can be used for example for the soundtrack list in AdvancedSlideshow as well.
Right now those buttons and slots are not used anywhere...

Andi