| Summary: | thumbnail borders are drawn inside instead of outside the images thus hiding parts of the image | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Johannes Tögel <jtoegel42> |
| Component: | Thumbs-RAW | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | marcel.wiesweg |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 1.0.0 | |
| Sentry Crash Report: | |||
|
Description
Johannes Tögel
2009-09-07 20:45:17 UTC
If i remember, my code draw outside the image and do not crop contents... Marcel, do you have changed something with QT4 model view port ? Johannes, please test with beta4... Gilles I updated to beta4 and I've still got the same problem. It is noticeable especially well if the thumbnails are small. Just a minute and I'll provide a screenshot showing the problem. Johannes P.S.: Thanks for the immediate response! Here is the Screenshot (edited a bit for easier recognition of the problem) http://picfront.de/d/KQOTgf2q4/digikam_croppedthumbnails.jpg The second thumbnail under the digikam one I created myself, to be sure that it isn't an effect caused by thumbnail generation. I can confirm this.... "thumbnails are very important source of information and should be as accurate as possible" True but on the other hand drawing borders "inside" of image means thumbnail will be less minimized and details in thumbnail will be bigger. And only small areas near borders are lost, in big majority of photos not containing important informations. "True but on the other hand drawing borders "inside" of image means thumbnail will be less minimized and details in thumbnail will be bigger. And only small areas near borders are lost, in big majority of photos not containing important informations." No. There is so much whitespace around the thumbnails that it would be no problem to keep the current thumbnail size AND draw the borders outside. So (of course depending on the photographers style) some or very much images will profit from this while the rest isn't affected negatively. Besides that, the real problem is that the "small area" can heavily affect the images' look, this is not the case with a somewhat smaller thumbnail. Johannes, your screenshot is from the thumbnail bar. Do you see this bug as well in the main icon view? If yes, can you please send me this butterfly picture for testing by private mail. I can see this bug in thumbbar and iconview... Ok I found it. It is the one-pixel "highlighting" frame drawn in ThumbnailLoadThread::slotThumbnailLoaded. I would not like to remove this border, it has been in the digikam icon view for ages. The solution would be to load thumbnails always 2 pixels smaller and add the frame. SVN commit 1028073 by mwiesweg: Do not cut off a one-pixel line at each side, but instead load the thumbnail 2 pixels smaller and add these by drawing the lines afterwards. BUG: 206666 M +3 -1 NEWS M +14 -4 libs/threadimageio/thumbnailloadthread.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1028073 |
