| Summary: | add irkick-compatible relative seek(sec) operation | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Andrew Gaydenko <a> |
| Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | benadler, ciro.scognamiglio, edward.hades, mzanetti, pfmiller |
| Priority: | NOR | ||
| Version: | 2.3-GIT | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Andrew Gaydenko
2009-09-02 19:41:10 UTC
Fixed by commit 3bff88683f0abeba6a03909f05a130fb4871738c Author: Michael Zanetti <michael_zanetti@gmx.net> Date: Mon Sep 7 12:19:42 2009 +0200 Added DBus functions Forward(int) and Backward(int)to Player src/dbus/PlayerDBusHandler.cpp | 12 ++++++++++++ src/dbus/PlayerDBusHandler.h | 3 +++ src/dbus/org.freedesktop.MediaPlayer.player.xml | 8 ++++++++ 3 files changed, 23 insertions(+), 0 deletions(-) *** Bug 206660 has been marked as a duplicate of this bug. *** Sorry, I fail to see how the two bugs are related. The original bug is about D-Bus methods, mine is about the signals amarok sends. I took a look at your commit and I think it's completely irrelevant to the bug. Unfortunately, opening the issue. Have got A2 2.1.85 (under Kubuntu Karmic testing), both functions - Forward and Backward - just seek 1-2 sec back. For both I have set the parameter as 20 in IRKick config. Try 20000, they're in milliseconds, IINM. For both functions max value is 99. (In reply to comment #6) > For both functions max value is 99. Is this still an issue? Should be fixed in latest kdelirc. Michael, I'm able to set, say, 20000 now, thanks! The problem is, seeking doesn't work for me even with mouse (playing stops for few seconds, seek bar jumps back and such). So, it seems like another bug takes place (A2 2.20 is in use under Kubuntu Karmic testing), and lirc related one - this bug - can be closed. With RC seek bar behavior is now the same as with seeking via mouse (stopping and jumping back and such). I'll report at case any lirc-related problem will nevertheless be discovered after A2 seeking be cured. OK. So I'll close this bug as the relative seek functions are implemented in amarok and the integer limit to 99 is fixed in kdelirc. If there are other problems with amarok please report them a separate bugs to give appropriate developers a chance to find bug reports by just reading the subject line. I think that Forward(int) and Backward(int) are rather problematic. It's not clear whether it'll seek (X seconds? X milliseconds?) or forward/rewind X tracks in the playlist. I know there's next() and prev(), but thats not a good enough excuse for having such undescriptive seeking methodnames. How about allowing negative numbers and using "Seek(int)"? Or maybe SeekMS(int)? Just an idea. I can't change the value from ms to s bechause all other functions work with ms too. That's because it is defined like this in the MPRIS spec. All other players following the MPRIS spec (VLC, XMMS etc) also work with ms. I implemented these functions at first as "seek(int)" but the amarok developers told me that they'd like to have it as Backward() and Forward(). I'll update the amarok profile in kdelirc to have a template argument of 10000. So it should be clear for everyone to use ms here (if there is a need to change the default value). |