Summary: | Crashes when attempting to save playlist to MTP device | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Ben Cooksley <bcooksley> |
Component: | Playlists/Saved Playlists | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aikawarazuni, bart.cerneels, eyecreate |
Priority: | NOR | ||
Version: | 2.3-GIT | ||
Target Milestone: | 2.3.1 | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Ben Cooksley
2009-09-02 06:53:58 UTC
IS this reproducible every time? Also with different playlists? It is always reproducible. Were the tracks in the playlist all from the mediaplayer? Might be fixed in v2.1.85-106-gde02c89. We're tagging rc1 tonight, please check as soon as possible so we can fix this before 2.2 final. *** Bug 210193 has been marked as a duplicate of this bug. *** Ben, can you reproduce this with current git? Whilst it no longer crashes: The playlist keeps its initial name and is not renamed when the name is changed through Amarok's interface ( even though it shows the new name ) The playlist itself is empty, in both Amarok's interface and on the device. Also, there is no indication the playlist comes from a remote device. Well, at least the crash is gone :) Bart, any input on the other problems? Something is going wrong in the MTPHandler, for both saving and renaming it seems. This is why Alejandro is CC'd. We don't show playlists per device yet, but this is planned somewhere in the 2.2 cycle. Please create a new bug for this if you want to track progress. This might potentially have been fixed by this commit (in Git master), please test, and reopen the report if the problem persists. Thanks. commit acf150893523a4c1693abb2ccae32f91140cb01d Author: Mark Kretschmann <kretschmann@kde.org> Date: Mon Dec 21 08:53:42 2009 +0100 Fix many MTP crashes caused by dangling pointers. The main cause for many crashes in MtpHandler were dangling pointers to structures from LibMTP. Using the new QSharedPointer (from Qt 4.5) makes it easy to fix such issues elegantly and safely. Please consider using it in other places too. It's often worth the tiny overhead. Note: I'm not sure how many bug reports this affects. Probably several. |