Bug 205903

Summary: accentuated chars are converted into a mess during picasa web export [patch]
Product: [Applications] digikam Reporter: gpetetin
Component: Plugin-WebService-GoogleAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, clement.cc, tschenser
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed In: 1.1.0
Sentry Crash Report:
Attachments: Patch agianst kipi-plugins-0.8.0
New patch with fix for multiple tags from bug 199145

Description gpetetin 2009-09-01 17:36:57 UTC 
Version:            (using KDE 4.3.0)
OS:                Linux
Installed from:    Fedora RPMs

As an example, the french sentence "définitivement un problème avec les accents, là" becomes "définitivement un problème avec les accents, lÃ" on the web album.

--
digiKam version 0.10.0
Exiv2 peut écrire dans un fichier Jp2: Oui
Exiv2 peut écrire dans un fichier Jpeg: Oui
Exiv2 peut écrire dans un fichier Png: Oui
Exiv2 peut écrire dans un fichier Tiff: Oui
Exiv2 prend en charge les méta-données XMP: Oui
LibCImg: 130
LibExiv2: 0.18.2
LibJPEG: 62
LibJasper: 1.900.1
LibKDE: 4.3.00 (KDE 4.3.0)
LibKExiv2: 0.6.0
LibKdcraw: 0.5.0
LibLCMS: 118
LibPNG: 1.2.37
LibQt: 4.5.2
LibRaw: 0.7.2
LibTIFF: LIBTIFF, Version 3.8.2 Copyright (c) 1988-1996 Sam Leffler Copyright (c) 1991-1996 Silicon Graphics, Inc.
Élément graphique Marble: 0.8
LibGPhoto2: 2.4.5
Libkipi: 0.4.0
Comment 1 Siu Chung (Clement) Cheung 2009-11-23 02:00:46 UTC 
Same problem with Chinese characters. This is because there's a bug in the Picasa plugin's version of mpform.cpp:

72 	bool MPForm::addPair(const QString& name, const QString& value, const QString& contentType) 

95 	 str += "Content-Length: " ;
96 	str += content_length.toAscii();
97 	str += "\r\n\r\n";
98 	str += value.toUtf8();
99 	str += "\r\n";
100 	
101 	m_buffer.append(str.toUtf8()); 

str is already in utf8 when we convert value to utf8. But we convert it again before adding it to m_buffer. Obviously that will screw up all the special characters. I have no idea why each plugin wants to have his copy of the exact same thing. But the bug was apparently fixed on the Flickr plugin's copy of the exact same file:

<http://websvn.kde.org/trunk/extragear/graphics/kipi-plugins/flickrexport/mpform.cpp?r1=879160&r2=879161&>

Copying the latest code over from the flickr copy fixes the issue.

The patch attached fixes both #199145 and #205903.
Comment 2 Siu Chung (Clement) Cheung 2009-11-23 02:02:35 UTC 
Created attachment 38518 [details]
Patch agianst kipi-plugins-0.8.0
Comment 3 Siu Chung (Clement) Cheung 2009-11-25 11:46:51 UTC 
Created attachment 38568 [details]
New patch with fix for multiple tags from bug 199145
Comment 4 Jens Mueller 2010-01-03 19:22:41 UTC 
The patch is included in https://bugs.kde.org/attachment.cgi?id=38567 and already applied with https://bugs.kde.org/show_bug.cgi?id=199145#c18 . So I'm closing this bug entry.