Bug 205740

Summary:	Cancelling the creation of a Distribution List File leaves an unused resource.
Product:	[Applications] kaddressbook	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	CLOSED NOT A BUG
Severity:	normal	CC:	tokoe
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	unused resource created after cancellation Snapshot

Description Sabine Faure 2009-08-30 23:53:19 UTC

Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Configure Akonadi with an IMAP and Kolab resource.
- Launch Kaddressbook
- Go to File/New/Add Address Book...
- Select the 'Distribution List File' feature in the 'Add Address Book' dialogue
- In the 'Select Distribution List' dialogue click on 'Cancel'
- Go to K menu/Systemsettings
- Go to the 'Advanced' tab and click on 'Akonadi Configuration'
- In the 'Akonadi Resources Configuration' tab there is an unused resource left from the cancellation. It is called : 'akonadi_distlist_resource_x'

Each time that the user cancels the creation of a distribution list such a resource is created and is stays unused.

Trunk, Svn Rev 1016607

Comment 1 Tobias Koenig 2009-09-21 12:52:14 UTC

SVN commit 1026284 by tokoe:

Add the configurationDialogAccepted/Rejected() signals to AgentBase

Make use of these signals in AgentInstanceCreateJob to remove the
new resource again if the user has canceled the initial resource
configuration.

BUG: 205740


 M  +1 -0      CMakeLists.txt  
 M  +1 -0      agentbase.cpp  
 M  +24 -0     agentbase.h  
 M  +41 -6     agentinstancecreatejob.cpp  
 M  +2 -0      agentinstancecreatejob.h  
 M  +2 -2      agentmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1026284

Comment 2 Sabine Faure 2009-09-23 23:21:48 UTC

The bug is still there and is still exactly the same.

Maybe I should have been more precise and told you that each time I said launch KAB I really meant launch Kontact and go to KAB.
This might be why this is not working for me.

Trunk, Svn Rev 1027237

Comment 3 Tobias Koenig 2009-09-24 07:38:17 UTC

Hej Sabine,

have you updated the Akonadi server as well?
You need a complete new compilation of the server, the libs and
the resources.

Ciao,
Tobias

Comment 4 Sabine Faure 2009-09-25 01:05:09 UTC

Hi Tobias,

Yes, every time I update my revision number, I update all the following:
kdesupport
kdelibs
kdepimlibs
kdepim

Is there anything more that needs to be updated?

Comment 5 Sabine Faure 2009-09-25 01:11:11 UTC

Created attachment 37164 [details]
unused resource created after cancellation Snapshot

The bug is still there.
I created a snapshot to help you understand what I mean.
After the cancellation, you can see that the resource has been created anyway. It even stays there if a new revision is compiled and used.

Trunk, Svn Rev 1027765

Comment 6 Sabine Faure 2009-10-09 19:45:32 UTC

I retested this today and the 'Distribution List File' resource has been removed from the 'Add Address Book' dialogue. So this bug is not valid anymore.

I tried with all the other resources just in case and there is no unused resource left in the 'Akonadi Configuration' dialogue when cancelling the creation of a resource.

So I am closing this bug.

Trunk, Svn Rev 1033074