| Summary: | bbc weather engine can't find my location | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Oliver Henshaw <oliver.henshaw> |
| Component: | widget-weather | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, annma, christian.nitschkowski, code, gerold.neuwirt, jamundso, kde, lukas, marcus, shawn.starr |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Find error using UK MET
bbcukmet.patch query parameters handling patch |
||
|
Description
Oliver Henshaw
2009-08-26 21:35:06 UTC
Try "United Kingdom" BBC search broke finding some places. Using country name gives more names. This won't be fixed because the search code they have makes this impossible for me to parse without knowing ahead of time what places only show up when using country vs exact name. It looks like the results for my town turn up in the area search, but are stripped out in the bbcukmet ion. Is it possible to re-add results from area searches, or would that cause more trouble? As I said, my problem has more to do with "area search" than country names. P.S. Have you got a list of problematic searches? If so I can try and re-enable area searches on my local machine and see if I can keep them working. I've got the same problem with the city of Duisburg (Germany). The weather applet suddenly stopped working for me some time during the KDE 4.3 beta phase. Searching for Duisburg on the BBC web page will get me the results. BBC broke searching again. It's bad enough area search was not working. I will need to backport the new URL changes that BBC made for 4.3.x series. Created attachment 40521 [details]
Find error using UK MET
BBC Weather can't find London. That's funny.
Ping. Jerry what KDE version? 4.4 branch is foxed and when you type 'London' you get all London possibilities. Confirmed, it stopped working somewhen in the middle of 4.3 series; using 4.3.4 here. The BBC ion doesn't actually find any location at all (In reply to comment #8) > Jerry what KDE version? 4.4 branch is foxed and when you type 'London' you get > all London possibilities. 4.3.4 (In reply to comment #10) > (In reply to comment #8) > > Jerry what KDE version? 4.4 branch is foxed and when you type 'London' you get > > all London possibilities. > > 4.3.4 and now, 4.3.5 also. - Could you recheck this with KDE SC 4.4.0 ? (may be related to bug 225020) Regards I have got the same problem with KDE 4.3.5 on Kubuntu. I deleted the plasmarc files in the kde config and thought it will be easy to reinstall the plasmadesktop. When I wanted to configure the weather plasmoid it just tells me that it can't find the place. To mention is also that the respond appears very fast for BBC, so I guess it doesn't even try to connect to the station. When I try the other two weather stations NOAA and Canada it seems that there is at least a fraction of a second response time. *** Bug 220841 has been marked as a duplicate of this bug. *** Do you reproduce with kde 4.4.4 or 4.5 beta ? Yeah, the bug is still present in 4.4.4. Don't have 4.5 beta installed, myself... It does not work well at all (4.5 branch) and there's even a new bug when you hit Enter after entering a location, Enter does not trigger the Search. Not sure if the not found locations are BBC related but entering a location through the BBC website works when it does not work through the applet. Created attachment 47918 [details]
bbcukmet.patch
I'm attaching a one character patch that fixed this bug for me (the patch is against KDE 4.4.3 as that is the version I have installed).
Before the patch, a search for "Brno" would find 13 locations none of which would be the correct one. With the patch, the correct location is found.
I did a smoke test with a couple of cities around the world and got correct results each time ("London" gets multiple relevant results as expected).
SVN commit 1137208 by aseigo: start from the beginning, patch by Lukas Krejci BUG:205235 M +1 -1 ion_bbcukmet.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1137208 Created attachment 47920 [details]
query parameters handling patch
This is another patch (that includes the original one-liner) that fixes the "Rochford problem" mentioned above by capturing and passing along the additional query parameters that can be applied to the RSS URLs (i.e. the "area" query parameter in this concrete case).
oh, forgot to mention that second patch should fix the bug 226194 as well... |