Bug 205094

Summary:	Text in KDE Help->About dialogs is cut off by a few pixels
Product:	[Plasma] Oxygen	Reporter:	Alan Jenkins <alan.christopher.jenkins>
Component:	style	Assignee:	Camilla Boemann <cbo>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hugo.pereira.da.costa
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Screenshot of four affected dialogues konqueror kaboutdialog. Left: before, wrong. Right: after, correct

Description Alan Jenkins 2009-08-25 16:13:40 UTC

Version:            (using KDE 4.3.0)

All the KDE "About" dialogs seem to be a few pixels too narrow.  This cuts off a few pixels on the end of the link to the GPL.

Comment 1 Alan Jenkins 2009-08-25 16:14:18 UTC

Created attachment 36437 [details]
Screenshot of four affected dialogues

Comment 2 Christoph Feck 2009-08-25 22:51:08 UTC

I can only reproduce with Oxygen. The KDE version texts need to be short, as in the screen shot, so you will probably not be able to reproduce with trunk.

Comment 3 Hugo Pereira Da Costa 2009-10-21 05:37:39 UTC

Fixed in trunk (that was a missing "case" statement in OxygenStyle::subElementRect). See screenshot.

r1038325 runtime/trunk/KDE/kdebase/runtime/kstyles/oxygen/oxygen.cpp

Comment 4 Hugo Pereira Da Costa 2009-10-21 05:38:52 UTC

Created attachment 37697 [details]
konqueror kaboutdialog. Left: before, wrong. Right: after, correct

Comment 5 Hugo Pereira Da Costa 2009-10-21 16:37:36 UTC

SVN commit 1038638 by hpereiradacosta:

More fixing on tabwidget contents and tabbar layout.
Fixes conflict between r1038325 and r1037814 (and layout for konqueror, konversation, etc.)
CCBUG: 205094
CCBUG: 193893



 M  +12 -2     oxygen.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1038638

Comment 6 Hugo Pereira Da Costa 2009-11-28 18:44:08 UTC

Argh.
Had to un-fix this bug, to fix a more serious one.
Re-open this one untill re-fixed.

Comment 7 Hugo Pereira Da Costa 2009-11-28 20:38:16 UTC

SVN commit 1055813 by hpereiradacosta:

Fixed (for good) layouts in tabwidgets. Notably make sure that long labels do not 
get cut (such as in About dialogs), when using default margin and minimum size. 
The issue is apparently in kstyle. Fixed if using QCommonStyle::subElementRect for 
SE_TabWidgetTabContents.
BUG: 205094


 M  +7 -0      oxygen.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1055813

Comment 8 Hugo Pereira Da Costa 2009-11-29 23:20:41 UTC

SVN commit 1056351 by hpereiradacosta:

another attempt at fixing bug 205094.
Reimplemented kstyle::sizeFromContents( CT_TabWidget ), to fall back on default tab orientation (horizontal) when option 
cannot be casted.
BUG: 205094


 M  +13 -0     oxygen.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1056351