Bug 205093

Summary: dsymutil=yes needs quotes, locking
Product: [Developer tools] valgrind Reporter: Dan Kegel <dank>
Component: generalAssignee: Rhys Kidd <rhyskidd>
Status: REPORTED ---    
Severity: normal CC: pjfloyd, rhyskidd
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: blocking3.5.1   
Platform: Compiled Sources   
OS: macOS   
See Also: https://bugs.kde.org/show_bug.cgi?id=207613
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Simply adds quotes around the path being passed to dsymutil.
Simply adds quotes around the path being passed to dsymutil.

Description Dan Kegel 2009-08-25 16:12:25 UTC 
Version:            (using Devel)
OS:                OS X
Installed from:    Compiled sources

1. dsymutil=yes fails for binaries with spaces in
their filenames; adding quotes fixes that.

2. dsymutil=yes runs multiple instances of dsymutil
on same file if you happen to be valgrinding a
multiprocess application; locking is needed to avoid this.

Easy-ish workaround until those are fixed: run dsymutil manually.
Comment 1 Julian Seward 2009-08-25 16:34:19 UTC 
Err, at least (1) is lame and easy to fix.  Marking as blocking3.5.1.
Comment 2 Dan Kegel 2009-08-25 16:41:04 UTC 
Aw, #2 should be easy, too.  I'll try to submit a patch for both later today.
Comment 3 Dan Kegel 2009-08-26 01:51:26 UTC 
Decided to go with the approach in bug 205000 instead,
as manipulating dsym files turns out to be a can
of worms (and running dsymutil for chromium takes 20 minutes on
a 2.8GHz quad-core Xeon, probably much longer on our Mac Mini test bots, 
which is prohibitive).
Comment 4 Dave MacLachlan 2010-07-14 22:21:23 UTC 
Created attachment 49156 [details]
Simply adds quotes around the path being passed to dsymutil.

Here's a patch to add quotes around the path being passed to dsymutil.
Comment 5 Dave MacLachlan 2010-07-14 22:23:20 UTC 
Created attachment 49157 [details]
Simply adds quotes around the path being passed to dsymutil.

Here's a patch to add quotes around the path being passed to dsymutil.
Comment 6 Julian Seward 2010-07-21 18:00:58 UTC 
Quoting fix committed as r11219 (thanks for that).  The locking
issue remains unresolved.