Bug 204882

Summary: Cancelling cover manager does not work
Product: [Applications] amarok Reporter: Claus Appel <spectrumdt>
Component: generalAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: normal CC: k.dummann, nhn, stuffcorpse
Priority: NOR Keywords: release_blocker
Version: 2.3-GIT   
Target Milestone: 2.2.2   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:

Description Claus Appel 2009-08-23 17:25:27 UTC 
Version:           2.1.1 (using 4.2.4 (KDE 4.2.4), 4.2.4-6.fc11 Fedora)
Compiler:          gcc
OS:                Linux (i686) release 2.6.29.6-217.2.3.fc11.i586

When opening the Amarok cover manager (Tools -> Cover Manager), it pops up with a progress bar and a "Cancel" button. This "Cancel" button does not work. Clicking it does not cancel anything. I have to wait until the cover manager is fully loaded before I can close it.
Comment 1 Mikko C. 2009-08-23 18:14:04 UTC 
Confirmed in git master of today.
Comment 2 Kolja 2009-09-15 00:18:39 UTC 
I made a simple patch for this. 

http://gitorious.org/amarok/amarok/merge_requests/1512
Comment 3 Mark Kretschmann 2009-09-30 15:33:05 UTC 
This patch doesn't work here, sorry. Pressing "Cancel" does nothing at all.
Comment 4 Myriam Schweingruber 2009-11-16 17:50:20 UTC 
Any news on this? The "Cancel" button when loading the thumbnails still doesn't work.
Comment 5 Myriam Schweingruber 2009-11-30 16:40:47 UTC 
Setting keyword
Comment 6 Nikolaj Hald Nielsen 2009-12-22 12:27:17 UTC 
commit 8e07631d40e6eee6edb3ec03e9e407e82c49e2e0
Author: Nikolaj Hald Nielsen <nhn@kde.org>
Date:   Tue Dec 22 09:27:26 2009 +0100

    Make the "cancel" button when loading thumbnails in the cover manager work.
    The issue was that the not processing events in every iteration apparently made most user events simply dissapear.
    The more frequent processing caused secere flickering in the actual cover view when loading the items, so as a workaround, a dummy empty view is shown untill all covers have been loaded (or the cancel button is pressed).
    This has the added benefit of making cover loading significantly faster.
    BUG: 204882