| Summary: | konqueror leaves files downloaded via ftp:// with .part extension | ||
|---|---|---|---|
| Product: | [Unmaintained] kio | Reporter: | Maciej Mrozowski <reavertm> |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | faure, finex, hikaru.luce, sng |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | possible fix (apply to kdelibs/kioslave/ftp/ftp.cpp.diff) | ||
|
Description
Maciej Mrozowski
2009-08-21 03:54:29 UTC
Did you have stopped the download before its end? Well, please read step 3. When the file download is completed the .part file should be renamed. Is the checksum of the .part file correct matching the correct one? Right, I could have added it to initial bug report. Yes, file is fully downloaded, just .part suffix not removed. Please try to reproduce for yourself though (in 4.3 branch) (Un)fortunatly I cannot reproduce the bug using current trunk. I don't have KDE 4.3 installed now. Can you reproduce in dolphin too? Probably this is a dup of bug #203819 . Reproducible with dolphin as well. Bug #203819 refers to smb:// protocol anyway (ftp:// here), but it's indeed possible that fixing one will fix the other. I'd keep them both anyway for now until fixed. I cannot reproduce on KDE 4.3 (ArchLinux), both using konqueror and dolphin. ".part" suffix is removed correctly after download. I cannot repdoce bug #203819 too. Well, it may have been patched in ArchLinux or regression introduced after 4.3.0 has been released (I reported bug against 4.3 svn branch). Someone with recent snapshot of 4.3 branch (so 4.3.1 wannabe) would need to test it. This bug is still here ( kde 4.3.1 ) I just checked it, and this is the status: Still reproducible with 4.3.3, but... bug should be called: "konqueror ignores 'Mark partially uploaded files' option. When I select this option: - konqueror marks partially downloaded file appending .part to filename AND renames file back to original one when download completed When I deselect this option: - konqueror STILL marks partially downloaded file with .part suffix (bug) and LEAVES it not renamed (correct behaviour) when completed Haven't checked whether trunk is affected yet, but definitely 4.3 branch, reproduced on clean account. Is this a dup of bug #209070 ? Created attachment 38452 [details] possible fix (apply to kdelibs/kioslave/ftp/ftp.cpp.diff) Here's a possible fix for this problem, kio_ftp was indeed not handling correctly the case where .part files are disabled. I coded this on a plane so I couldn't test it, please give it a try. AFAICS it should work :-) Reply to comment #12: No, I don't think so. Tested with 4.3 branch - confirmed to fix this issue (it should fix for trunk as well). David, do the honors! :) Thanks SVN commit 1053170 by dfaure: Fix kio_ftp downloading files as "foo.part" instead of "foo" when disabling(!) the "Mark partially uploaded files" feature. CCBUG: 204605 M +12 -12 ftp.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1053170 SVN commit 1053171 by dfaure: Fix kio_ftp downloading files as "foo.part" instead of "foo" when disabling(!) the "Mark partially uploaded files" feature. Fixed for: 4.3.4 BUG: 204605 M +12 -12 ftp.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1053171 |