Bug 204502

Summary:	Not encrypted messaged in an OTR session are not saved to history
Product:	[Unmaintained] kopete	Reporter:	Gerrit Visscher <gerrit>
Component:	OTR Plugin	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mzanetti, pali.rohar, walch.martin
Priority:	NOR
Version:	0.70.90
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/kopete/b977f1f701afd1f9192f35e0263f2f1c04bef53e	Version Fixed In:	4.12
Sentry Crash Report:

Description Gerrit Visscher 2009-08-20 11:41:32 UTC

Version:           0.70.90 (using 4.3.00 (KDE 4.3.0), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.30-gentoo-r4

If my chat partner ends the OTR session, Kopete keeps ist open. If he sends me an unencrypted message afterwards, the message is not displayed as a proper message but as a system message. So I don't get informed about this message and it is not saved to the history.
This ist somehow related to bug https://bugs.kde.org/show_bug.cgi?id=201074
If the OTR session would be closed automatically, this would probably not happen so often.

So, for the record: Expected behaviour: The messages should not be converted to system messages. :)

Comment 1 Michael Zanetti 2010-03-07 12:38:56 UTC

It is not possible to change this in kopete_otr because libotr already converts the message to an internal message. According to the libotr devs this will be fixed in libotr-4.

However, libotr is currently lacking some manpower and is asking for help to finish version 4.
If anybody is interested in helping out, here is the call for volunteers:
http://lists.cypherpunks.ca/pipermail/otr-dev/2010-February/001108.html

Comment 2 Martin Walch 2013-06-12 16:26:47 UTC

(In reply to comment #1)
> It is not possible to change this in kopete_otr because libotr already
> converts the message to an internal message. According to the libotr devs
> this will be fixed in libotr-4.

libotr 4 has been released in September 2012. What is the resulting impact on this bug report?

Comment 3 Michael Zanetti 2013-06-12 18:18:51 UTC

I haven't managed to find the time yet to update to libotr 4. I know it has some interesting features but also requires some deeper changes in the plugin to make use of them.

Comment 4 Michael Zanetti 2013-06-24 22:53:33 UTC

FYI: https://git.reviewboard.kde.org/r/111227/

feel free to test it and let me know how it works.

Comment 5 Michael Zanetti 2013-09-17 17:17:35 UTC

Git commit b977f1f701afd1f9192f35e0263f2f1c04bef53e by Michael Zanetti.
Committed on 24/06/2013 at 22:20.
Pushed by mzanetti into branch 'master'.

ported otr plugin to libotr 4.0.0
Related: bug 195328, bug 218570, bug 298681, bug 304105, bug 306276, bug 309987, bug 318255

M  +1    -3    CMakeLists.txt
M  +5    -5    cmake/modules/FindLibOTR.cmake
M  +17   -16   plugins/otr/authenticationwizard.cpp
M  +1    -1    plugins/otr/authenticationwizard.h
M  +1    -1    plugins/otr/kopete_otr.desktop
M  +1    -1    plugins/otr/otrguiclient.cpp
M  +1    -1    plugins/otr/otrguiclient.h
M  +455  -316  plugins/otr/otrlchatinterface.cpp
M  +42   -7    plugins/otr/otrlchatinterface.h
M  +2    -6    plugins/otr/otrlconfinterface.cpp
M  +1    -1    plugins/otr/otrlconfinterface.h
M  +22   -68   plugins/otr/otrplugin.cpp
M  +1    -1    plugins/otr/otrplugin.h
M  +1    -1    plugins/otr/otrpreferences.cpp
M  +1    -1    plugins/otr/otrpreferences.h
M  +1    -1    plugins/otr/privkeypopup.cpp
M  +1    -1    plugins/otr/privkeypopup.h

http://commits.kde.org/kopete/b977f1f701afd1f9192f35e0263f2f1c04bef53e