| Summary: | local contrast tool issues | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Mikolaj Machowski <mikmach> |
| Component: | Plugin-Editor-LocalContrast | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, julien.pontabry, Julien, languitar |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/c7bf359c7e563be57417f302b5846dde01f0169b | Version Fixed In: | 2.9.0 |
| Sentry Crash Report: | |||
|
Description
Mikolaj Machowski
2009-08-19 23:25:10 UTC
To Julien Pontabry, Do you see this entry from Mik in Bugzilla ? Gilles Caulier To Gilles, Yes I do. "Tone Mapping" is a good name (as "Pseudo-HDR" does) because it is exactly what the algorithm does. Julien SVN commit 1032246 by cgilles: rename plugin action from "Local Contrast" to "Tone Mapping" CCBUGS: 204466 M +3 -3 imageplugin_localcontrast.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1032246 SVN commit 1032249 by cgilles: set internal tool name as "Tone Mapping" CCBUGS: 204466 M +3 -3 localcontrasttool.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1032249 Julien, Instead to use "Stage" 1/2/3/4, why not to use "Tone Map" 1/2/3/4 or something like that ? Gilles Caulier Gilles, This are author's words. Sure it may be better. To me, using different stages are not very usefull : I get best results with only one stage... This comes maybe from my pictures ? Julien I find this stages stuff very confusing, and I guess the average user might do so, too. What does it do? For me the results are all the same, so what is the difference? I have always turned on all 4 stages, since this was the default setting. I'm agree. I cannot see a difference with more than one Stage to use Look code, there is a loop to apply Stage on image : http://lxr.kde.org/source/extragear/graphics/digikam/imageplugins/localcontrast/ToneMappingFloat.cpp#63 Gilles I agree as well. I don't understand how the stages are supposed to be used. I think this feature could be removed. Anyway an expert user could simulate the stages by applying the filter several times. I don't see why there is a "function" option either. The "power function" option gives better results for me than linear. If everybody has the same opinion maybe this option could be deleted as well. The "low saturation" and "high saturation" could be renamed into "shadow saturation" and "highlights saturation". Julien Please, leave at least 2 stages. I was never able to get decent results from this plugin with one stage. With two it is much easier. Mikolaj, Interesting ! could you please provide an example picture and the settings you are using for the two stages ? Julien What about making the number of stages editable and defaulting to one stage? This would be a reasonable default for beginners with a clean gui. Via a drop down we could provide more stage bloating up the gui... After reflection, i think to change "Local Contrast" to "Tone Mapping" is a wrong idea. Look in internet, "Tone Mapping" is a method using more than one image to make HDR. This is not the case here. This can confuse end user. http://en.wikipedia.org/wiki/Tone_mapping A lots of internet page are in French (if you enter Tone Mapping). All speak about more than one image to use and to fuse. I think that we cannot use Tone Mapping ask plugin name there. Local Contrast is more adapted. Gilles SVN commit 1032563 by cgilles: fix High/Low Saturation to Highlight/Shadow Saturation CCBUGS: 204466 M +4 -4 localcontrasttool.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1032563 It difficult to find the best name for this plugin. I think "ToneMapping" describe only the process to compress the dynamic range of a picture. It is usually applied to high dynamic range (HDR) pictures generated from several low dynamic range pictures but it can be applied to a single picture as well. People often call this "single raw hdr", where is in fact it is more "Tone mapping from a single raw" in my opinion. It seems to me that this plugin implements some kind of ToneMapping applied to a single picture (either a raw file with a moderate dynamic range or a 8bit file with low dynamic range). The "local constrast" name is short and quite intuitive and does not confuse the user with multiple picture hdr tonemapping. We could also use the following names : "Dynamic range compression" "LDR Tone Mapping" Julien What about "contrast improvement"? SVN commit 1032737 by cgilles: revert Tone Mapping name to Local Contrast. Can be confuse for end user CCBUGS: 204466 M +1 -1 imageplugin_localcontrast.cpp M +10 -10 localcontrasttool.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1032737 "contrast improvement" : too simple, and we have already Brightness/Contrast/gamma action in editor. Can be confuse... Gilles Caulier And whats about Unsharp Mask settings which is disabled currently in code ? Gilles Mik, This file still valid using digiKam 2.x serie ? Gilles Caulier Git commit c7bf359c7e563be57417f302b5846dde01f0169b by Gilles Caulier. Committed on 22/08/2012 at 18:51. Pushed by cgilles into branch 'master'. don't use downscaled image to render preview, it will differs than final rendering Related: bug 235601 M +4 -3 imageplugins/enhance/localcontrasttool.cpp http://commits.kde.org/digikam/c7bf359c7e563be57417f302b5846dde01f0169b |