Bug 204347

Summary:	chat-command "clear" doesn't give a warning when msg received within last second
Product:	[Unmaintained] kopete	Reporter:	Dominik Geyer <dominik.geyer>
Component:	Chat Window	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	mattr
Priority:	NOR
Version First Reported In:	0.70.90
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch: Add a warning for clearing the chat if there are unread messages.

Description Dominik Geyer 2009-08-19 00:43:05 UTC

Version:           0.70.90 (using KDE 4.3.0)
Compiler:          g++ (Gentoo 4.3.2-r3 p1.6, pie-10.1.5) 4.3.2 
OS:                Linux
Installed from:    Gentoo Packages

There's a feature in kopete which checks for recently received messages when the user wants to close the chatview - this prevents the user from missing a message in the same moment he tries to close the window.

However, there's a command "clear" which is an IRC-style command for clearing the current view. There are no checks for recently arrived messages so the user might miss an important message.

My proposal is:

bool ChatView::closeView( bool force )
- Move the message-warning code to a seperate method.

void ChatView::clear()
- Call this new method from within the clear-command and the closeView


I could do a patch if it's appreciated.

Comment 1 Matt Rogers 2009-09-06 21:44:30 UTC

Yes, a patch for this would be awesome.

Comment 2 Dominik Geyer 2009-09-06 23:32:37 UTC

Following patch differs from my inital proposal. It's just an additional check of unreadMessageFrom and introduces a new string for the clear-warning. The patch is based on released kde-4.3.1.

Comment 3 Dominik Geyer 2009-09-06 23:36:08 UTC

Created attachment 36748 [details]
Patch: Add a warning for clearing the chat if there are unread messages.

Comment 4 Matt Rogers 2009-09-19 06:09:57 UTC

SVN commit 1025560 by mattr:

Add a warning to the clear command.

Patch by Dominik Geyer. Thanks!

BUG: 204347

 M  +11 -1     chatview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1025560