Bug 203768

Summary:	Copy/cut/paste menu/shortcut should be disabled if not a valid option
Product:	[Applications] konsole	Reporter:	Christopher Stone <chris.stone>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	finex
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed In:	4.8
Sentry Crash Report:

Description Christopher Stone 2009-08-13 23:05:48 UTC

Version:            (using KDE 4.3.0)
OS:                Linux
Installed from:    Fedora RPMs

The word "Copy" is misleading when there is no text highlighted on the konsole. I think the menu option should be renamed to "Clear Clipboard" or something similar, or else greyed out (which many other user interfaces do, such as this textarea element in Mozilla Firefox.)

I would prefer "Clear Clipboard" because that is what it actually does, and greying it out prevents me from clearing my clipboard with a right click which I think would be innovative and cool.

Not to mention easy to implement (hopefully) ;-)

Okay, so what do you think about this idea?

Comment 1 FiNeX 2009-08-15 11:20:11 UTC

I don't agree to change the label because it could add extra confusion to users: nothing is selected, so nothing is copied. If having the copy action which copies nothing causes difficulties, it should be disabled, not renamed.

Comment 2 Christopher Stone 2009-08-15 17:32:18 UTC

Yes, please disable it at a minimum.

The renaming option was only if you wanted to be innovative.

But the status quo would be to just disable it.  It is quite confusing as it is now, otherwise I would not have filed this bug.

This is coming from an experienced computer programmer and 10-year veteran linux user.  I'm sure if it confuses me, it will confuse my Aunt Tilly. ;-)

Comment 3 Christopher Stone 2009-08-15 17:39:47 UTC

BTW, I became confused when I was trying to select a URL link in the konsole using the context menu.  I had known that you could copy links from the konsole using the context menu, so I activated the context menu with a right click on top of the URL and noticing the Copy option was available, I selected that.  Then I had to figure out why it wasn't actually copying the link. After closer inspection I noticed the "Copy Link Location" menu option in the context menu.  So this is actually where the confusion lied with me.  Had the copy option been greyed out, I'm sure I would have selected "Copy Link Location" on the first try.

Comment 4 Kurt Hindenburg 2010-01-17 23:57:51 UTC

I renamed this wish per #2 and so this wish could be tracked.

Comment 5 Jekyll Wu 2011-08-26 18:13:45 UTC

Git commit f5772ab06b4f640b5cdb3d5be8f93183f2258cd8 by Jekyll Wu.
Committed on 26/08/2011 at 18:56.
Pushed by jekyllwu into branch 'master'.

Enable copy action only when some text are selected.

FEATURE: 203768
FIXED-IN: 4.8

M  +12   -0    src/Session.h
M  +11   -0    src/SessionController.cpp
M  +9    -0    src/Emulation.h
M  +9    -0    src/Emulation.cpp
M  +7    -0    src/SessionController.h
M  +2    -0    src/ViewManager.cpp
M  +7    -0    src/Session.cpp

http://commits.kde.org/konsole/f5772ab06b4f640b5cdb3d5be8f93183f2258cd8