| Summary: | Country names in digikam should come from iso_3166 GNU package | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Freek de Kruijf <f.de.kruijf> |
| Component: | Plugin-Generic-MetadataEdit | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, freekdekruijf, jlayt, mboquien |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 2.5.0 | |
| Sentry Crash Report: | |||
|
Description
Freek de Kruijf
2009-08-12 20:06:44 UTC
The country names are already available in translated from from KGlobal::locale()->countryCodeToName(QString countryCode). You can use KGlobal::locale()->allCountriesList() to obtain a list of all Country Codes. This assumes kdebase/runtime/i10n is installed which may not always be the case. This adheres my point that adding all these names to digiKam, which end up in digikam.pot, are not necessary. Gilles, what about this one? A small correction to my earlier point, kdebase/runtime is a prerequisite for all KDE apps, so you can always rely on the full list of translated country names being available from KLocale. I fear that Digikam cannot use allCountriesList() if i believe the comment in digikam/libs/template/countryselector.cpp: // We cannot use KLocale::allCountriesList() here because KDE only // support 2 characters country codes. XMP require 3 characters country // following ISO 3166 (http://userpage.chemie.fu-berlin.de/diverse/doc/ISO_3166.html) At least not until it support 3 characters country codes then. Now the list of countries in digiKam is rather limited. So I would suggest to use a translation table between the currently used two character country codes and the 3 character codes used in XMP. This avoids translation of country names in more than two places. I've been looking for an excuse to add support for the 3 character code into KLocale, I'll try sort something out this week in time for 4.4. Not immediately useful for you, but I'd agree with the code translation table idea for the interim rather than adding new translation strings. I have a table of the entities currently supported in KDE and their various codes at kdebase/runtime/l10n/entities.ods if you need something to copy/paste. Freek, This entry still valid ? Gilles Caulier Yes, the names of the countries are now in kipiplugin_metadataedit.pot Right. In digiKam, Countries list has disappear due to factoring in libkexiv2. This must be done too into MetadataEdito kipi-plugin. Gilles Caulier Git commit 2e5176efad629443588b3dd77887b9fa89957051 by Gilles Caulier. Committed on 13/12/2011 at 12:36. Pushed by cgilles into branch 'master'. remove country name/code definition and use factored list provided by libkexiv2 BUGS: 203603 M +14 -283 metadataedit/iptc/iptcorigin.cpp M +10 -278 metadataedit/xmp/xmporigin.cpp http://commits.kde.org/kipi-plugins/2e5176efad629443588b3dd77887b9fa89957051 Thanks very much. |