Bug 203532

Summary:	IRKick-related regression: some functions don't work, some not declared
Product:	[Applications] amarok	Reporter:	Andrew Gaydenko <a>
Component:	general	Assignee:	Amarok Bugs <amarok-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	edward.hades
Priority:	NOR
Version First Reported In:	2.1.1
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Andrew Gaydenko 2009-08-12 10:28:52 UTC

Version:           2.1.1 (using KDE 4.3.0)
OS:                Linux
Installed from:    Ubuntu Packages

These Player::functions (declared by Amarok in IRKick config wizard) do nothing:

Player::VolumeUp
Player::VolumeDown

These functions are missed (in comparison with 1.x Amarok):

showOSD(seconds)
seek(seconds)

Comment 1 Seb Ruiz 2009-08-12 15:22:57 UTC

VolumeUp and VolumeDown need to be passed explicit arguments (since dbus converts no arguments to the explicit 0)

seek is replaced by PositionSet() and PositionGet().

I've just implemented ShowOSD() as a method in /Player, you can find the commit here:

http://gitorious.org/amarok/amarok/commit/4623e1eead1fe13ff6da3ddf059a9b3b95ea85d6

Comment 2 Andrew Gaydenko 2009-08-12 15:54:51 UTC

Seb,

Thanks for fast addition!

The problems are:

- VolumeUp and VolumeDown don't declare any arguments in IRKick wizard,
- saying about seek(seconds) I mean relative seek in seconds. Currently, say, PositionSet accepts an argument in 0..10 range and at any case set position to a beginning of the track.

Will you be so kind to look at these issues?

Comment 3 Edward Hades 2009-09-02 19:29:41 UTC

Andrew, the volumeUp and volumeDown issue is most probably fixed along with #205729. Please test if it is.

Regarding seek(): will you please open a separate wish report for it?

Comment 4 Andrew Gaydenko 2009-09-02 19:43:13 UTC

Edward,

Thanks!

As for seeking - done: http://bugs.kde.org/show_bug.cgi?id=206028

Comment 5 Andrew Gaydenko 2009-09-12 22:20:11 UTC

Edward,

A day ago I have upgraded A2 to 2.1.80 (Kubuntu Karmic). The issue still exists  - both volume up and down does nothing. Don't know how to check the fix existence in this version. Probably I must wait for next beta/RC.

Comment 6 Edward Hades 2009-09-13 18:17:46 UTC

(In reply to comment #5)
> A day ago I have upgraded A2 to 2.1.80 (Kubuntu Karmic). The issue still exists
>  - both volume up and down does nothing. Don't know how to check the fix
> existence in this version. Probably I must wait for next beta/RC.

The fix was made after beta1 release, so, yes, please hold for next version ;)