Bug 203485

Summary: consider using KGlobalSettings::picturesPath() instead of KGlobalSettings::documentPath()
Product: [Applications] digikam Reporter: Oliver Henshaw <oliver.henshaw>
Component: Setup-CollectionsAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles, marcel.wiesweg, rdieter
Priority: NOR    
Version: 1.0.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Unspecified   
Latest Commit: Version Fixed In: 1.0.0

Description Oliver Henshaw 2009-08-11 23:36:10 UTC 
Version:            (using Devel)
Installed from:    Compiled sources

I've set up xdg-user-dirs (Video, Documents, Pictures, etc.) on my system and am interested at how well they are integrated in kde. I see that they are provided by KGlobalSettings and looked on lxr to see what uses them.

Currently, KGlobalSettings::documentPath() has a lot of users in digikam, showfoto and kipi-plugins. Would KGlobalSettings::picturesPath() be more appropriate in some of these cases?

See http://lxr.kde.org/search?string=documentPath%28%29 for examples. (These results are from trunk,  I guess that's where digikam development is. I don't know if there's a good permanent url, this will always show current users.)
Comment 1 caulier.gilles 2009-08-12 11:07:42 UTC 
I'm agree to use picture path by default, but the question is : which KDE version include this settings to picture path ?

Another question is : digiKam can drive video too. what we can do with video path settings from KDE ?

Gilles Caulier
Comment 2 Marcel Wiesweg 2009-08-12 19:14:08 UTC 
For the default collection path we already use picturesPath() (utilities/firstrun/collectionpage.cpp).
Most places where we use documentPath() are located in the image plugins, I assume for storing settings. I guess it's appropriate for this purpose.
One occurrence in digikamapp.cpp (location for importing) should be changed to picturesPath. Same probably for showfoto.cpp.
Comment 3 Marcel Wiesweg 2009-09-26 18:06:22 UTC 
SVN commit 1028318 by mwiesweg:

Replace two occurences of documentPath() with picturesPath().
For the remaining occurences documentPath() is suitable because it is not about pictures,
but tool settings.

BUG: 203485

 M  +3 -1      NEWS  
 M  +7 -1      digikam/digikamapp.cpp  
 M  +10 -2     showfoto/showfoto.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1028318