Summary: | Dolphin generates thumbnails for images larger than the preset limit | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Falk <faah> |
Component: | general | Assignee: | Peter Penz <peter.penz19> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | brendon |
Priority: | NOR | ||
Version: | 16.12.2 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Falk
2009-08-07 15:14:50 UTC
Thanks for the report! I cannot reproduce this issue when previewing image files (the size limit is respected in the Information Panel, the tooltips and the views). The size limit is only ignored when creating image previews for directory thumbnails, which is a bug - did you mean this? SVN commit 1011074 by ppenz: Respect the maximum file size when creating thumbnails for directories. BUG: 202960 M +11 -2 thumbnail.cpp M +1 -0 thumbnail.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1011074 SVN commit 1011075 by ppenz: Backport of SVN commit 1011074: Respect the maximum file size when creating thumbnails for directories. CCBUG: 202960 M +11 -2 thumbnail.cpp M +1 -0 thumbnail.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1011075 I just checked it and you are right the file size is/was only ignored when dolphin had to create thumbnails for the directories. Thx for the fast bug fix :) This bug, and bug #203512, make me wonder why the code for generating folder thumbnails, createSubThumbnail(), duplicates functionality that's already part of the get() method. Surely it would be a more robust approach to refactor the code such that the common functionality resides in its own method (or methods) that's called by get() and createSubThumbnail(). :-/ FWIW. Thanks Brandon for the hint! I'm not the maintainer of the class Thumbnail, but I'll have a look on this if I need to apply another patch in future... SVN commit 1011482 by ppenz: Assure that the thumbnails of directory previews don't exceed the cache size. Thanks to Brendon Higgins for the detailed analyses. BUG: 203512 CCBUG: 202960 M +15 -8 thumbnail.cpp M +6 -0 thumbnail.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1011482 SVN commit 1011483 by ppenz: Backport of SVN commit 1011482: Assure that the thumbnails of directory previews don't exceed the cache size. Thanks to Brendon Higgins for the detailed analyses. BUG: 203512 CCBUG: 202960 M +15 -8 thumbnail.cpp M +6 -0 thumbnail.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1011483 |