Summary: | BQM: sharpen tool resets EXIF orientation | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Frank Zacharias <fzachi> |
Component: | Plugin-Bqm-Sharpen | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | marcel.wiesweg, tschenser |
Priority: | NOR | ||
Version: | 1.0.0 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 1.0.0 |
Description
Frank Zacharias
2009-08-02 11:27:58 UTC
The same seems to be true for the resize tool Looking at the source of BatchTool and ActionThread, d->exifSetOrientation is always true, and not changed by any tool, so for all tools, the orientation tag will be reset to NORMAL. I would suggest to be more precise with the wording ("resetExifOrientation") and default to false - which tools need to reset the orientation tag? Gilles, this bug should be fixed as well. As I see it, only Flip and Rotate need to reset the rotation flag, all other tools should not touch this flag. Ok? Yes Marcel, only these both tools must do that... Gilles SVN commit 1063913 by mwiesweg: There were two different settings merged in one: - the user allows to edit the exif orientation - from digikam settings - the tool needs to reset the flag - only flip and rotate need that. Treat this distinctly, so that not all images processed by BQM have their orientation reset. BUG: 202278 M +2 -1 NEWS M +2 -2 utilities/queuemanager/actionthread.cpp M +1 -1 utilities/queuemanager/actionthread.h M +2 -0 utilities/queuemanager/basetools/transform/flip.cpp M +2 -0 utilities/queuemanager/basetools/transform/rotate.cpp M +25 -12 utilities/queuemanager/batchtool.cpp M +12 -4 utilities/queuemanager/batchtool.h M +1 -1 utilities/queuemanager/queuemgrwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1063913 (In reply to comment #5) > - the tool needs to reset the flag - only flip and rotate need that. Marcel, what about converter tools (png, tiff, jpeg, ...)? Please have look on https://bugs.kde.org/show_bug.cgi?id=221113#c4 Jens |