| Summary: | restart/logout notification are shown before update completes | ||
|---|---|---|---|
| Product: | [Unmaintained] kpackagekit | Reporter: | Steven M. Parrish <smparrish> |
| Component: | general | Assignee: | Steven M. Parrish <smparrish> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dantti12, oliver.henshaw |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Steven M. Parrish
2009-08-01 01:30:17 UTC
Well there are some reasons the notification icon do not show which package caused it: - the restart signal can be called various times, and i'm unable to update the notification, unless i kill it and create a new one, which is ugly. - updating the tool tip is easier since i have access there. The restart as Richard said is issued by the backend tool which imo should only emit it when it finished it's job. IMO this isn't a valid report, i'll keep it open for a while if you think i missed a point. Comment #5 From Richard Hughes (rhughes@redhat.com) 2009-08-08 08:32:21 EDT (-) [reply] ------- (In reply to comment #4) > I see that upstream believes that the timing of the notifications is the > responsibility of the packagekit backend. No, it's up to the frontend to take the notifications whenever they happen and batch them up to show the user at the end. There's nothing in the spec about when signals have to come during the transaction. Sorry, that's me clumsily quoting Richard Hughes in the downstream bug ( https://bugzilla.redhat.com/show_bug.cgi?id=513755 .) Contrary to my statement in the original report that "when the update is complete, a restart icon appears in the systray," the icon is always in the systray throughout the update, it's just hidden under the stack of jobs in the kpackagekit icon. Yes, about the icon you are right, I don't want to waste systray space since if you have running tasks why would you want to restart? I'll note that if you batch notifications until the end of the update, you could show the list of packages in the notification as well as in the kpackagekit tooltip. Ok, for KPackageKit 0.5 I decided to store the restarts and print them at the end, since a backend will emit require restart more than once if multiple packages requested it, the only problem is that I don't know how the pop up will looks like when 100 packages caused it... This has re-appeared in Fedora 12, perhaps triggered by a PackageKit update (the kpackagekit version has remained stable for a while). PackageKit-0.5.7-2.fc12.i686 kpackagekit-0.5.4-2.fc12.i686 If early notifications appear, it's now at a predictable point in the packagekit transaction. See https://bugzilla.redhat.com/show_bug.cgi?id=553356#c2 for further details and some console output. |