Bug 202043

Summary:	huge icons for attachments in kmail when mimetype icon only exists as svg
Product:	[Applications] kmail2	Reporter:	Janet <bugzilla>
Component:	UI	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bjoern, montel, novalore, w01dnick
Priority:	NOR
Version:	4.12.3
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	screenshot screenhot KDE SC 4.5.3/Kmail 1.13.5 screenshot kmail2 KDE SC 4.12.3

Description Janet 2009-07-31 01:06:14 UTC

Version:            (using KDE 4.2.96)
OS:                Linux
Installed from:    Debian testing/unstable Packages

Kmail seems to use the smallest available icon size to display the icons for mail attachements.

When the mimetype icon is only available in svg a 256x256 (?) sized icon is displayed, when the icon is available in svg and 128x128 png a 128x128 icon is displayed. Both is too large for both the top and the bottom of the mail.

Expected behaviour, at least from a user's point of view: kmail should always show small attachement icons at the top of the mail (22x22?) and medium symbols at the bottom of the mail (64x64?). If the mimetype icon is not available in that size it should be scaled down to avoid messing up the layout and readabilty of the mails.

Comment 1 Björn Ruberg 2010-03-02 00:19:41 UTC

Could you provide a screenshot?

Comment 2 Janet 2010-03-05 15:57:46 UTC

Created attachment 41355 [details]
screenshot

Comment 3 Björn Ruberg 2010-03-05 17:30:31 UTC

Thanks!

Comment 4 Janet 2010-11-28 14:34:44 UTC

Created attachment 53826 [details]
screenhot KDE SC 4.5.3/Kmail 1.13.5

The problem still exists with KDE 4.5.3 and kmail 1.13.5 though it now looks a little different. The icon in the mail header that links to the attachment now has the size of the small icons, which is as it should be. But the attachment icon below the mail is huge, really huge.

The icon theme does contain the mimetype icons in all necessary sizes and also as svg. 

I propose that the attachment icons displayed below the mail content follow the size of the desktop icons as set in systemsettings.

Comment 5 Laurent Montel 2012-07-03 14:11:03 UTC

Still valid in 4.9 ?

Comment 6 Laurent Montel 2012-07-04 06:57:28 UTC

Git commit 94d3fb4dbe64a7fbb910e34b8944bcf22a101de0 by Montel Laurent.
Committed on 04/07/2012 at 08:56.
Pushed by mlaurent into branch 'KDE/4.9'.

Start to fix Bug 202043 - huge icons for attachments in kmail when

mimetype icon only exists as svg
Limit size of icon.

M  +9    -3    messageviewer/viewer_p.cpp

http://commits.kde.org/kdepim/94d3fb4dbe64a7fbb910e34b8944bcf22a101de0

Comment 7 Janet 2014-04-12 14:23:34 UTC

Created attachment 86059 [details]
screenshot kmail2 KDE SC 4.12.3

Still valid in kmail2 and KDE SC 4.12.3 (screenshot taken in Linux Mint 16, with svg only icon theme Flamini from kde-look.org).

Comment 8 Mykola Krachkovsky 2014-04-13 01:24:17 UTC

Confirm this bug for Kontact/KMail 4.12.4.

Comment 9 novalore 2016-03-11 11:59:13 UTC

Confirm the bug on kmail 5.0.2 Using:
KDE Frameworks 5.15.0
Qt 5.4.2 (built against 5.4.2)
The xcb windowing system

The icon set in use is Antu2

Comment 10 Laurent Montel 2016-03-11 15:34:55 UTC

For me it's ok in 5.1.3 or 5.2