Bug 201374

Summary:	emacs or save are the only options for attachment handling
Product:	[Unmaintained] kmail	Reporter:	David Rankin <drankinatty>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde-2011.08, kollix
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description David Rankin 2009-07-24 19:30:18 UTC

Version:            (using KDE 4.2.98)
Installed from:    SuSE RPMs

When a bash script is received as an attachment to an email in kmail, the only options presented to the user after clicking on the attachment are to "open with 'emacs'" (what? are you kidding) or save. There is no option to open in another editor despite the "Advanced Embedded Editor" (kate) being set in default applications.

The easiest way to send new users running back to windows or gnome is to have them open anything in emacs. kmail should respect the "default application" setting and at least default to opening text attachments in kate or kwrite. kmail should also let the user choose what application or editor to open the attachment with. Presenting emacs as the only default choice is a huge bug. Heck presenting the user with 'vim' would at least be kinder.

So here, kmail needs to provide a drop down allowing the user to choose the application *with* the "Browse..." option also provided since kmail doesn't keep track of all text editors installed. Certainly change the default to anything other than emacs.

screenshot of current behavior:

http://www.3111skyline.com/download/openSUSE_bugs/kde4/screenshots/kmail-emacs.jpeg

Comment 1 Dotan Cohen 2009-07-25 10:08:52 UTC

I think that this is a good case for a generic change to the open/save dialogs used in Kmail Konqueror and other places. Particularly, the "open" dialog should have a default as is currently the case, plus the ability to open other applications as well (similar to the Open With dialogue in Dolphin).

Note that Mozilla applications work this way: the user is presented with three choices:
1) Open with Default
2) Open with... <browse installed applications>
3) Save


David, would you agree with making the bug more generic?

Comment 2 Martin Koller 2009-08-02 23:07:19 UTC

I'm proposing a patch on the review board.

Comment 3 Martin Koller 2009-08-02 23:16:14 UTC

see http://reviewboard.kde.org/r/1219/

Comment 4 Martin Koller 2009-08-05 23:26:03 UTC

SVN commit 1007520 by mkoller:

BUG: 201374

always add an "open with" button, even if we know the application which can
open the attachment


 M  +1 -0      CMakeLists.txt  
 A             attachmentdialog.cpp   [License: GPL (v2+)]
 A             attachmentdialog.h   [License: GPL (v2+)]
 M  +13 -18    kmreaderwin.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1007520