Bug 201218

Summary:	Kontact summary view uses window text colour when it should use view text colour
Product:	[Applications] kontact	Reporter:	Peter Lewis <pete>
Component:	summary	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	christophe, winter
Priority:	NOR
Version:	SVN trunk
Target Milestone:	---
Platform:	unspecified
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Patch to make Kontact summary view use the correct colours for the colour scheme.

Description Peter Lewis 2009-07-23 13:49:45 UTC

Version:            (using KDE 4.2.96)
Installed from:    Unlisted Binary Package

As the short description says really. If you choose a dark view background with light text, and a light window background with dark text, then the summary view text is unreadable.

Further testing shows that it seems that the summary view is using the window text colour rather than the view text colour, even though it's in a view, and uses the view background colour.

Thanks.

Comment 1 Peter Lewis 2009-07-24 15:02:33 UTC

Created attachment 35596 [details]
Patch to make Kontact summary view use the correct colours for the colour scheme.

Hi again. I'm fairly new to Qt hacking, so this might not be the "right" way to do this, but the attached patch appears to do the job.

Comment 2 Allen Winter 2009-07-24 16:19:47 UTC

yep, looks good.

i'll commit and backport for the 4.3 release.
Thanks!  feel free to make more patches :)

Comment 3 Allen Winter 2009-07-24 17:26:13 UTC

SVN commit 1001946 by winterz:

Make the Kontact summary view uses view text color instead of window text color.
Thanks for the patch Peter.

also be nicer to the rightToLeft folks with the stylesheet.

BUG: 201218
MERGE: 4.3,e4


 M  +20 -1     summaryview_part.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1001946

Comment 4 Allen Winter 2009-07-24 17:26:54 UTC

SVN commit 1001947 by winterz:

Backport r1001946 by winterz from trunk to the 4.3 branch:

Make the Kontact summary view uses view text color instead of window text color.
Thanks for the patch Peter.

also be nicer to the rightToLeft folks with the stylesheet.

CCBUG: 201218
MERGE: 4.3,e4



 M  +20 -1     summaryview_part.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1001947

Comment 5 Peter Lewis 2009-07-24 17:45:15 UTC

Thanks for accepting the patch. I think now I'll take a look through some other bug reports... :-)