Bug 201014

Summary:	Playlist layout: items with width set to 1% behave the same as automatic width
Product:	[Applications] amarok	Reporter:	Ralf Jung <post>
Component:	Playlist/Playlist Layout Editor	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	aspotashev, nhn, sam
Priority:	NOR
Version:	2.2-SVN
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/amarok/22f63afcd297dd661f0ce9e0ce6e92a92df69628	Version Fixed In:	2.7
Sentry Crash Report:
Attachments:	The playlist wasting space for diviers, which are set to a cstom 1% width (Amarok 2.3.0)

Description Ralf Jung 2009-07-21 18:18:52 UTC

Version:           2.2-SVN (using 4.2.4 (KDE 4.2.4), Kubuntu packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.28-13-generic

When I have much information displayed per track, it gets hard to see what 
information is what. In the old playlist, the borders of the columns served 
that purpose. The new one has "dividers", but they take away a huge lot of 
space. If, instead of dynamically growing, the dividers would be just as wide 
as they are drawn (10 pixels, perhaps) and the items containing actual 
information can take up all the remaining space, that would be a big 
improvement.

Comment 1 Myriam Schweingruber 2010-09-05 11:43:18 UTC

Setting the divider width to Custom 1% should solve that, no? I can't see any problems here with that setting.

Comment 2 Ralf Jung 2010-09-08 20:17:30 UTC

No, it does not work. Even after setting the width to 1%, the playlist looks like shown on the screenshot I will attached - tons of space wasted by the dividers, but the track names elided because they are too long to fit into the space left.

Besides, I would argue that dividers should never expand in width, even if it is set to automatic.

(btw, am I supposed to change the status when providing information to a WAITINGFORINFO bug? Don't know the etiquette in this case, sorry)

Comment 3 Ralf Jung 2010-09-08 20:18:20 UTC

Created attachment 51437 [details]
The playlist wasting space for diviers, which are set to a cstom 1% width (Amarok 2.3.0)

Comment 4 Myriam Schweingruber 2010-09-09 09:32:46 UTC

Thank you for your feedback. Yes, you can change the status when you give feedback, that would be nice :)
Changing status to confirmed. I had to actually modify my screen resolution to see the problem.

Comment 5 Wyatt Epp 2012-08-21 02:43:13 UTC

This is actually a bug in the width setting.  1% causes it to behave exactly like the "Automatic" setting. (2% and such work just fine).

Comment 6 Sam Lade 2012-08-22 13:53:35 UTC

Git commit 22f63afcd297dd661f0ce9e0ce6e92a92df69628 by Sam Lade.
Committed on 22/08/2012 at 15:51.
Pushed by lade into branch 'master'.

Fix playlist layout 1% width being treated as auto

Items set with a custom fixed width of 1% were erroneously being treated
as if they were set to automatic width.
FIXED-IN:2.7

M  +1    -1    src/playlist/layouts/LayoutEditWidget.cpp

http://commits.kde.org/amarok/22f63afcd297dd661f0ce9e0ce6e92a92df69628