Bug 200854

Summary: Option to clear light table on close [PATCH]
Product: [Applications] digikam Reporter: Pieter Edelman <p.edelman>
Component: Setup-LightTableAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Unspecified   
Latest Commit: Version Fixed In: 1.0.0
Attachments: Option to clear light table on close

Description Pieter Edelman 2009-07-20 12:57:26 UTC 
Version:            (using KDE 4.2.4)
Installed from:    Unspecified Linux

When I close the light table, it is usually because I am done using it for the current batch of (similar) photos. I also usually forget to clear it when I'm done :) The result is that when I add a new batch of photos to the light table, the old one is still present.

I've attached a simple patch that adds a configuration option to clear the light table automatically when the user closes it. This option is present in the Digikam configuration menu and can be added to the light table toolbar.
Comment 1 Pieter Edelman 2009-07-20 12:58:05 UTC 
Created attachment 35477 [details]
Option to clear light table on close
Comment 2 caulier.gilles 2009-07-20 13:21:26 UTC 
Pieter,

I'm agrre to add this option (i thinking to do the same in fact)

But the option must going on Light Table setup panel, not LT configuration menu. We need to still coherent here. Look setup LT code :

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/setup/setuplighttable.cpp

Note : Your patch need to be built against code from svn trunk.

Thanks in advance for your contrib...

Gilles Caulier
Comment 3 Pieter Edelman 2009-07-20 13:52:10 UTC 
Ok, thanks for the feedback.

The option actually is in the setup panel (Settings->Configure digiKam and then selecting Light Table), but I made it available from the toolbar as well. I can remove that, please let me know.

The patch is against the latest SVN trunk.

Pieter
Comment 4 caulier.gilles 2009-07-20 14:02:13 UTC 
SVN commit 999717 by cgilles:

apply patch from Pieter Edelman to clear Light Table contents on close event.
BUGS: 200854


 M  +10 -0     lighttable/lighttablewindow.cpp  
 M  +2 -0      lighttable/lighttablewindow_p.h  
 M  +12 -1     setup/setuplighttable.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=999717