Summary: | Adding a "recently modified lines" system | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | Jean-Marie Favreau <jm.trivial> |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | bugzilla |
Priority: | HI | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.8.0 | |
Sentry Crash Report: | |||
Attachments: | Virtual example of the suggested system |
Description
Jean-Marie Favreau
2009-07-19 11:30:48 UTC
Created attachment 35455 [details]
Virtual example of the suggested system
Another idea is to use vertical bars as in qt-creator http://www.qtsoftware.com/images/products/screenshot-qt-creator-editor. This indicates what lines are new and saved. We could even have a look at how they implement it. The main advantage of the scroll bar choice is the overview of the integral document. The navigation is more easy with this approach. However the two approaches are mutually complementary. *** Bug 170082 has been marked as a duplicate of this bug. *** Btw, perfectly suited as a GSoC project. Git commit c5946bf2c15bf166be3f83c93c0ac49396582c94 by Dominik Haumann. Committed on 03/09/2011 at 22:20. Pushed by dhaumann into branch 'master'. implement line modification system TODO: - unit test - improve visual appearance - enable / disable in config page - optionally show modified lines in scroll bar - fine tuning PS: Qt Creator's line modification system is totally buggy :^) Example: http://wstaw.org/m/2011/09/03/plasma-desktopgz5185.jpg CCBUG: 200753 CCMAIL: kwrite-devel@kde.org M +3 -2 part/undo/kateundomanager.h M +14 -1 part/view/kateviewhelpers.cpp M +326 -14 part/undo/kateundo.cpp M +31 -8 part/undo/kateundomanager.cpp M +34 -1 part/buffer/katetextline.h M +5 -0 part/buffer/katetextbuffer.h M +53 -36 part/undo/kateundo.h M +3 -6 part/document/katedocument.cpp M +43 -4 part/buffer/katetextblock.cpp M +9 -0 part/buffer/katetextbuffer.cpp M +5 -0 part/buffer/katetextblock.h http://commits.kde.org/kate/c5946bf2c15bf166be3f83c93c0ac49396582c94 Implemented for KDE 4.8 and works perfectly! If you want, you can try it already now: http://kate-editor.org/get-it/ It does not have scroll-bar marks yet, though. It could be added optionally, but it does not scale: For each modification (typing a character for instance), we'd have to iterate over all lines to repaint the marks in the scrollbar correctly. |