Summary: | konversation crashed while selecting a different tab | ||
---|---|---|---|
Product: | [Applications] konversation | Reporter: | Shawn Starr <shawn.starr> |
Component: | general | Assignee: | Konversation Developers <konversation-devel> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Shawn Starr
2009-07-14 04:30:50 UTC
SVN commit 996715 by modax: executeDelayedItemsLayout() on the nicknameListView after deleting the nick. This should ensure QTreeWidget internals do not keep deleted QTreeWidgetItem pointers around. This commit should solve the bug #200123. If you ever experience it again and/or the backtrace somewhat matches, please reopen the bug. BUG:200123 M +1 -1 commit.h M +2 -0 irc/channel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=996715 commit f3968507fc6815154ea6ac8a58555899ca7b58ab Author: Modestas Vainius <modestas@vainius.eu> Date: Tue Jul 14 18:54:31 2009 +0000 executeDelayedItemsLayout() on the nicknameListView after deleting the nick. This should ensure QTreeWidget internals do not keep deleted QTreeWidgetItem pointers around. This commit should solve the bug #200123. If you ever experience it again and/or the backtrace somewhat matches, please reopen the bug. BUG:200123 svn path=/trunk/extragear/network/konversation/; revision=996715 diff --git a/src/commit.h b/src/commit.h index b14462f..acf95b2 100644 --- a/src/commit.h +++ b/src/commit.h @@ -1,4 +1,4 @@ // This COMMIT number is added to version string to be used as "patch level" #ifndef COMMIT -#define COMMIT 3419 +#define COMMIT 3420 #endif diff --git a/src/irc/channel.cpp b/src/irc/channel.cpp index 1c72eae..04ffeab 100644 --- a/src/irc/channel.cpp +++ b/src/irc/channel.cpp @@ -1461,6 +1461,8 @@ void Channel::removeNick(ChannelNickPtr channelNick, const QString &reason, bool { nicknameList.removeOne(nick); delete nick; + // Execute this otherwise it may crash trying to access deleted nick + nicknameListView->executeDelayedItemsLayout(); } else { |