Summary: | Over-active repaint behaviour causes slowness | ||
---|---|---|---|
Product: | [Applications] KSquares | Reporter: | Casper van Donderen <casper.vandonderen> |
Component: | general | Assignee: | Matt Williams <matt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | casper.vandonderen, kde-games-bugs |
Priority: | NOR | ||
Version: | 0.4 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Casper van Donderen
2009-07-08 00:16:34 UTC
Can you try if setting QGraphicsScene::NoIndex to the scene fixes the problem too? In both SVN and 4.3 setting this->setItemIndexMethod(QGraphicsScene::NoIndex) in the constructor of gameboardscene.cpp does not work, the reapints still all happen. the index is set nowhere else. I think i know the problem, there are two combined problems: * Qt sucks at rendering long dashed lines * KSquares uses lots of long dashed lines Can you check that disabling dashes, by chaning QPen feintPen(Qt::DotLine); to QPen feintPen; in gameboardscene.cpp give you a noticeable gain? It did for me If that's the case and you have time, you should try converting the long dashed lines to short ones, that is doing one per square side instead one per each "row" I checked alot when I was trying to fix it and it is already using short dashed lines, that was something i thought that was the problem. When you click a line it overlays a non-dashed line at the position of a dashed line. it does a line->getindex -> draw new line at that position type scheme to add a move. Casper SVN commit 1011981 by aacid: backport r1011979 | aacid | 2009-08-16 16:30:25 +0200 (Sun, 16 Aug 2009) | 3 lines QGraphicsScene does not like items being deleted without being removed and that cuases lots of redraws BUGS: 199354 M +9 -1 highlightanimation.cpp M +1 -0 highlightanimation.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1011981 Forgot to add comment: When starting with quickstart with 4 computer players the filling of squares is still slow Closing, there's no huge repainting anymore, just that the AI blocks (bug 204061) |