| Summary: | xmp_sdk/common/LargeFileAccess.cpp: size of array ‘check_off_t_size’ is negative | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Friedrich W. H. Kossebau <kossebau> |
| Component: | Plugin-Bqm-DngConverter | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahuggel, kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.5.0 | |
| Sentry Crash Report: | |||
| Attachments: | Patch from Angelo Naselli to fix broken XMP SDK compilation under 64 bits computer | ||
|
Description
Friedrich W. H. Kossebau
2009-07-06 11:19:56 UTC
Title of the report seems to be limited in size, so here the complete compiler log: /home/koder/Kode/kdesvn/trunk/extragear/graphics/kipi-plugins/dngconverter/dngwriter/extra/xmp_sdk/common/LargeFileAccess.cpp:525: error: size of array ‘check_off_t_size’ is negative confirming this on my 32bit mandriva This code is XMP SDK from Adobe. files source code are copied as well from original tarball provided by Adobe : http://www.adobe.com/devnet/xmp/sdk/eula.html I just update code from 2007 release to 2008 release. Andreas, with old code (2007) of XMP sdk included in Exiv2 core, are you fixed something like that, based on exempi work: http://libopenraw.freedesktop.org/wiki/Exempi Gilles The Exiv2 version of XMP-SDK doesn't have this particular file. Either it was added in the new release (Exiv2 still uses the old release) or I didn't copy it from the XMP SDK (Exiv2 only uses the Core part, not the Files part of the XMP SDK). Besides, yes, I did port some fixes from Exempi. See the repository for details: http://dev.exiv2.org/repositories/browse/exiv2/trunk/xmpsdk Andreas Created attachment 35095 [details]
Patch from Angelo Naselli to fix broken XMP SDK compilation under 64 bits computer
Friedrich,
Please test this patch on your computer...
Gilles Caulier
i am trying this patch on a 64bit host and it builds OK Hi Gilles, (In reply to comment #5) > Created an attachment (id=35095) [details] > Patch from Angelo Naselli to fix broken XMP SDK compilation under 64 bits > computer > > Friedrich, > > Please test this patch on your computer... Nope, no change. The line in question is static char check_off_t_size [ (sizeof(off_t) == 8) ? 1 : -1 ]; and it might only be solvable if off_t is 8 byte long. No idea where off_t comes from. A first glance at the websearch result on off_t hints that anticipations about the size of off_t is a real problem. :( of course that doesn't change anything on 32 bit. i searched and on 32bit sizeof(off_t) == 4 on 64bit sizeof(off_t) == 8 Gilles, Can you simply remove the file? From a quick look it seems that only the XMPFiles component needs this stuff. So if your converter doesn't use that, you may get away without compiling this. Andreas SVN commit 992321 by cgilles: With DNG converter, this file can be dropped from XMP sdk CCBUGS: 199129 M +0 -2 CMakeLists.txt D dngwriter/extra/xmp_sdk/common/LargeFileAccess.cpp D dngwriter/extra/xmp_sdk/common/LargeFileAccess.hpp WebSVN link: http://websvn.kde.org/?view=rev&revision=992321 Thanks Andreas. Yes these files can be removed. Nicolas, Friedrich, can you try again with current implementation from trunk ? Gilles Caulier Yes, 992331 now compiles for me. :) BTW: Thanks for Digikam, I am discovering this program only now, and am really satisfied! perfect for me too |