Summary: | plasma crash after right clicking on folderview applet | ||
---|---|---|---|
Product: | [Unmaintained] plasma4 | Reporter: | Sebastian Schwarzl <s.schwarzl> |
Component: | widget-folderview | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | andresbajotierra, antonio_coniglio, aseigo, finex, fredrik, gdarecki, kendragonXXI, luizromario, Nontenda, stephane.betton, vanboxem.ruben |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | Proposed patch |
Description
Sebastian Schwarzl
2009-07-01 09:32:33 UTC
It looks similar to bug 195916. But this has a better backtrace. *** Bug 195916 has been marked as a duplicate of this bug. *** *** Bug 199659 has been marked as a duplicate of this bug. *** *** Bug 199861 has been marked as a duplicate of this bug. *** *** Bug 200122 has been marked as a duplicate of this bug. *** Bug 200122 mentions another situation related with the folderview widget too. Ok, I managed to reproduce this crash: Some previous details: (so the bug is easier to reproduce) - "Show confirmation for moving to trash" should be disabled - FoldeView should point to "desktop:/" (Desktop folder using the desktop kio protocol) Steps to reproduce: - Open Plasma or "plasmoidviewer folderview". - Create a folder "TEST" - Select the folder "TEST" - With the mouse near it, press "Del". The selected folder should move to the trash (without confirmation GUI), but as it is a bit slow ("desktop:/" related?), you can quickly move the mouse cursor over the folder. The popupview for that folder should appear, and after some time the legend "the file or folder TEST does not exist" (with a red cross). - Right click on that Popup: Plasma(or plasmoidviewer) should crash, as it is trying to check for the permissions of the root KFileItem (which was just deleted, so it will create a null KFileItem) (if you can't reproduce, try with another new folder, moving the mouse and hovering the invalid folder quickly) references: void PopupView::contextMenuEvent(QContextMenuEvent *event) KFileItem rootItem = m_model->itemForIndex(QModelIndex()); KFileItem item(rootItem.mode(), rootItem.permissions(), m_url); A possible solution would be catch "IconView::itemsDeleted" (which shows the message "file/folder unexistant") and invalidate/close the popup, or avoid the crash on right click. (check for some "invalid root path") I could reproduce the bug here using: Qt: 4.5.2 (KDE-Qt git commit 5b7a2eb42acfdea07c6075556cb43e2c95852145 Date: Tue Jul 28 14:10:47 2009 -0300) KDE: 4.3.63 (KDE 4.3.63 (KDE 4.4 >= 20090805)) kdelibs svn rev. 1009010 / kdebase svn rev. 1009010 on ArchLinux i686 - Kernel 2.6.30.4 *** Bug 203300 has been marked as a duplicate of this bug. *** Created attachment 36055 [details]
Proposed patch
SVN commit 1009770 by darioandres: Fixed for 4.4 by svn rev. 1009763 Backport to 4.3branch: In some situation, the Popup of the folderview may be still showing an invalid(non-existant) folder (case described on https://bugs.kde.org/show_bug.cgi?id=198499#c7) Right-clicking the popup will crash Plasma as it is trying to read a field from an invalid KFileItem) - Add a check for KFileItem(rootItem)::isNull and avoid showing the menu in that case BUG: 198499 M +6 -1 popupview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1009770 *** Bug 204204 has been marked as a duplicate of this bug. *** *** Bug 207317 has been marked as a duplicate of this bug. *** |