Summary: | digiKam should utilize _icc_profile X property | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Milan Knížek <knizek> |
Component: | ColorManagement-Profiles | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | caulier.gilles, marcel.wiesweg |
Priority: | NOR | ||
Version: | 0.10.0 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 1.0.0 | |
Sentry Crash Report: | |||
Attachments: | _ICC_PROFILE not recognised by digiKam |
Description
Milan Knížek
2009-06-25 10:44:23 UTC
SVN commit 1017858 by mwiesweg: Implementation to read ICC profiles set system-wide according to ICC profiles from X specification. Code taken gratefully from KOffice. CCBUG: 197817 M +4 -0 digikam/CMakeLists.txt M +76 -0 utilities/imageeditor/canvas/iccsettings.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1017858 SVN commit 1017859 by mwiesweg: Use profile returned from window system. Cache profile per screen (if set or not set). Marked as TODO for Windows and Mac (dont know the situation there). CCBUG: 197817 M +28 -5 iccsettings.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1017859 Any hint how to test this (that is, how to set such a profile)? @Marcel To set the property (you can use sRGB.icm for testing): $ xicc /path/to/your/profiles/display_profile.icm To check if it was set: $ xprop -root | grep _ICC_PROFILE The output should be a lot of numbers. If empty, then something's wrong. There are also other tools (dispwin) which do more things at once: load VCGT to calibrate the monitor (video card, actually) and also set the profile to X property. I will test myself - probably during the weekend. Created attachment 36718 [details]
_ICC_PROFILE not recognised by digiKam
While there are no options for getting the system monitor profile in the Settings, I assume it is supposed to work silently in the background.
However, it seems that _ICC_PROFILE property is ignored (digiKam svn 1020162, kipi-plugins 0.6.0, kde-4.2.2 in Ubuntu x64).
I used BRG.icc as the monitor profile set with xicc and sRGB as a monitor profile in digiKam Settings. If _ICC_PROFILE had priority above digiKam Settings, the images would be displayed with swapped colour channels like with EoG in the attachment.
Setting BRG.icc manually in the digiKam Settings works as expected -> ie. channels are swapped.
SVN commit 1020214 by mwiesweg: Use _ICC_PROFILE as atom name. The specification itself says it is _ICC_Profile, but though it should be right per definition (because it _is_ the specification), obviously it's wrong, at least dispwin uses _ICC_PROFILE. CCBUG: 197817 M +8 -5 iccsettings.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1020214 From where do I get this "xicc" tool? Dispwin completely messed up my display here and refuses to uninstall the profile it installed, and gives errors for every operation. It is part of the Ubuntu universe repository (Debian, too?). I am not sure, who actually maintains the code now, but a tar ball can be obtained here: http://packages.ubuntu.com/jaunty/xicc or directly at http://archive.ubuntu.com/ubuntu/pool/universe/x/xicc/xicc_0.2.orig.tar.gz digiKam svn 1020214: it works now as expected. Thanks, Marcel. As regards GUI: it would be nice to let the user know that digiKam found the "system" profile. E.g. the settings for the display profile could be greyed out and some message displayed instead. SVN commit 1022381 by mwiesweg: Signal in setup when system-wide monitor profile is set. CCBUG: 197817 M +20 -1 imageeditor/canvas/iccsettings.cpp M +10 -2 imageeditor/canvas/iccsettings.h M +10 -2 setup/setupicc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1022381 Now it is fine, unless some one else objects it, I would consider this for SOLVED. Thanks again, Marcel. Thanks for the feedback. I close this file now... Gilles Caulier |