Bug 197654

Summary: In Desktop Settings clicking 'OK' changes the background when in Slideshow
Product: [Unmaintained] plasma4 Reporter: Igor Cardoso <igordcard>
Component: wallpaper-imageAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: minor CC: asraniel, jtamate, kde, Sroka.Steven
Priority: NOR Keywords: junior-jobs, triaged
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Igor Cardoso 2009-06-23 21:20:25 UTC 
Version:            (using KDE 4.2.4)
Compiler:           Through ArchLinux official packages
OS:                Linux
Installed from:    Unlisted Binary Package

When we select in Desktop Settings that we want the wallpaper to be a Slideshow of many images and we click on apply, it will automatically change to a new image. I think this is a nice behaviour. However when we click the OK button it closes Desktop Settings as usual, but changes the background again. I think it would look much better without having the image changed on OK, at least when the Apply has been already clicked.
Comment 1 Jaime Torres 2010-01-03 12:02:32 UTC 
Still there in kde 4.4 beta 2.
Comment 2 Nicolas L. 2010-06-07 09:34:11 UTC 
valid on kde 4.4.4
Comment 3 Steven Sroka 2010-10-18 21:38:50 UTC 
Does anyone know where I can find the source code for the slideshow? I loved to fix this myself, since I have the same problem.
Comment 4 Beat Wolf 2010-10-19 10:21:06 UTC 
its in:
http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/

good luck! patches can be sent to reviewboard.kde.org

if you have any questions come to #plasma on freenode or write to the plasma-devel@kde.org mailing list
Comment 5 Aaron J. Seigo 2011-04-21 16:35:22 UTC 
Git commit 805544113d8ce4d8580776070126f1d747b1ee5a by Aaron Seigo.
Committed on 21/04/2011 at 16:42.
Pushed by aseigo into branch 'master'.

don't do anything if there is nothing to do

this prevents re-loading the wallpaper, particularly bad for slideshows

REVIEW:101159
BUG:197654

M  +4    -0    libs/plasmagenericshell/backgrounddialog.cpp     

http://commits.kde.org/kde-workspace/805544113d8ce4d8580776070126f1d747b1ee5a