Bug 197332

Summary:	wrongly translated selection from Marble widget
Product:	[Applications] marble	Reporter:	Mikolaj Machowski <mikmach>
Component:	general	Assignee:	Torsten Rahn <rahn>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	caulier.gilles, marcel.wiesweg, rahn
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Mikolaj Machowski 2009-06-21 00:19:34 UTC

Version:            (using Devel)
Compiler:          gcc4.3.2 
OS:                Linux
Installed from:    Compiled sources

When selecting random rectangle in digiKam *all* geolocated photos are shown. I suppose this is Marble problem though because console output shows this:

Marble: Starting selection
Marble: Leaving selection
Selection region: ( 185 ,  373 ) ( 217 ,  396 )

West:  -180  North:  90  East:  180  South:  37.1952

Marble: Starting selection
Marble: Leaving selection
Selection region: ( 231 ,  391 ) ( 266 ,  416 )

West:  -180  North:  90  East:  180  South:  31.5002

Marble: Starting selection
targetString "Earth"
Marble: Leaving selection
Selection region: ( 219 ,  157 ) ( 241 ,  177 )

West:  -180  North:  90  East:  180  South:  69.6654

timeChanged
void SunLocator::update()
Marble: Starting selection
targetString "Earth"
Marble: Leaving selection
Selection region: ( 234 ,  394 ) ( 260 ,  416 )

West:  -180  North:  90  East:  180  South:  31.841

Any selection selects whole northern hemisphere plus a bit of southern.

Both programs from trunk.

Comment 1 Marcel Wiesweg 2009-07-27 17:56:43 UTC

Mik I have been testing this just now. The Search works fine for me. Console output shows "real" coordinates like
West:  -6.4333  North:  53.4229  East:  -6.05754  South:  53.2336.

and the corresponding pictures are shown.
The selection rectangle is not shown on the marble map after it has been selected, but that's certainly a marble bug.

This console output is directly what we get from marble, so if the coordinates given span 75% of Earth's surface digikam will find you most of your geolocated pictures (except for yours from Antarctica ;-) )

KDE 4.3rc2 from openSuse.

Comment 2 Torsten Rahn 2009-07-28 12:41:05 UTC

> The selection rectangle is not shown on the marble map 
> after it has been selected, but that's certainly a marble bug.

No, it's not a Marble bug. The current way to "select" something is more about "selecting items inside the rect" than selecting an area (as the current API is not suited to select a truely rectangular API on the ground in terms of lat-lon). Therefore it's more comparable to selecting files in your file manager than selecting an area in a drawing application.

To get rid of the whole current messy implementation of the selection we'll introduce a new better API for Marble 0.9 which will draw the rectangle projected onto the ground and hence will deliver an exactl lat-lon-rectangle.
The current selection API will then get deprecated.

Comment 3 Mikolaj Machowski 2009-07-28 22:41:22 UTC

Looks like this was really something in digiKam, updated code from svn after recent big changes and looks like everything works OK.