Bug 196784

Summary: add more vertical space to widgets
Product: [Plasma] Oxygen Reporter: Maciej Pilichowski <bluedzins>
Component: styleAssignee: Camilla Boemann <cbo>
Status: RESOLVED NOT A BUG    
Severity: wishlist CC: cfeck
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: openSUSE   
OS: Unspecified   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Maciej Pilichowski 2009-06-16 19:02:54 UTC
Version:            (using KDE 4.2.90)
Installed from:    SuSE RPMs

Oxygen style adds to little space below the text (label). For edit box (with default size, on web pages) it means that letter "y" touches the edit box (or with 1 pixel space). This is too little to be readable. The same goes with buttons and so on -- there is enough clearance above, and this amount should be used below.
Comment 1 Camilla Boemann 2009-06-16 19:54:13 UTC
Oxygen doesn't have a problem. It's the html engines that doesn't respect the oxygen sizes.
Comment 2 Maciej Pilichowski 2009-06-16 20:13:59 UTC
Casper, sorry but reopening. Before posting this report I tested the same elements with Oxygen and Clearlook. The latter has required vertical space. And the webpage is the most clear case, but it is just an example.

You can also take a look at system settings buttons. Go to systemsettings, appearance, style, in the left, bottom corner is "Help" button. Choose oxygen style of course, and choose "apply". 

Now, please focus on "p" and "H" letters. Below p there is space of 4 pixels (exactly). Above "H" on the other hand is space of 8 pixels. 

Similar effect with widgets without icon -- "Oxygen" combobox. Below 4 pixels, above 9 pixels.

If you would like, I could attach screenshots.
Comment 3 Camilla Boemann 2009-06-16 22:09:41 UTC
No need to supply screenshots. This have been investigated before, even with help of the trolls.

Oxygen correctly tells any interested part what size it needs.

But that doesn't prevent any user (html engine or systemsettings) to ignore it and force their own size.

It's not an oxygen bug. -Closing again and please don't reopen
Comment 4 Maciej Pilichowski 2009-06-16 22:17:35 UTC
Casper, sorry for misunderstanding then.

Two questions though, because after all it is a problem, and closing report, does not help the situation. Let's focus on systemsettings:
a) which part is faulty here? SS? kdelibs? Qt?
b) somebody places the text at given location (in pixels) within button -- it is up to theme, kdelibs or Qt? 

Thank you in advance for your help.
Comment 5 Camilla Boemann 2009-06-16 22:35:11 UTC
The reason i close the report rather than reassign is that the bug lies everywhere so it's better to create a new bug for each case you find. Thanks for persevering though.

a) SS, probably either not using a layout at all or setting some properties on the layout that causes it.

b) the text placement within the button is up to qt, but the style (or kstyle) can influence it and via hacking also override it. I'm not quite sure where you are heading with this question though as it doesn't seem relevant to me at all
Comment 6 Maciej Pilichowski 2009-06-17 08:46:17 UTC
a) ok, so each end-client, right? Konqueror, SS and so on

b) I asked about this because it is not only making the widget slightly bigger (which oxygen tries to do, right?) but also to move the label up the little (after all spacing 8:4 is worse than 6:6, and the total space is exactly the same)

Ok, I am starting new reports.
Comment 7 Christoph Feck 2009-06-18 00:03:11 UTC
Widget sizes and vertical text position can be changed by the style freely. See how Skulpture does it.