Summary: | Implement a "Fill Screen" zoom mode that always fits the narrower axis of the image | ||
---|---|---|---|
Product: | [Applications] gwenview | Reporter: | Eike Hein <hein> |
Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | jaak, nate, null |
Priority: | NOR | Keywords: | junior-jobs |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/gwenview/ba63c8a44f463b883c03c77c942809cd238a6594 | Version Fixed In: |
Description
Eike Hein
2009-06-07 18:12:58 UTC
Good idea, added to my TODO list. Great, thanks a lot! :) As of at least Gwenview 16.12.3, there's now a "Fit" mode that does just this! Fill is not the same as fit. +1 on the idea. The new button should just replace the recently added "Fit Width" button. How about naming this just "Fill"? I'm always annoyed by how much space the switcher now takes, but don't really like making it a combobox either. Git commit ba63c8a44f463b883c03c77c942809cd238a6594 by Henrik Fehlauer, on behalf of Silas Lenz. Committed on 28/02/2018 at 09:16. Pushed by rkflx into branch 'master'. Replace "Fit Width" feature with "Fill" Summary: Fit width is arguably less useful than a more general Fill feature. This replaces "Fit Width" with "Fill", fitting width or height, depending on what fills the window. Test Plan: Use Fill with landscape and portrait pictures with the window in landscape and portrait size. Reviewers: #gwenview, ngraham, rkflx Reviewed By: #gwenview, ngraham, rkflx Subscribers: rkflx, muhlenpfordt, ngraham, #gwenview Tags: #gwenview Differential Revision: https://phabricator.kde.org/D10844 M +5 -4 doc/index.docbook M +5 -5 lib/documentview/abstractdocumentviewadapter.h M +15 -13 lib/documentview/abstractimageview.cpp M +4 -4 lib/documentview/abstractimageview.h M +19 -24 lib/documentview/documentview.cpp M +6 -6 lib/documentview/documentview.h M +19 -19 lib/documentview/documentviewcontroller.cpp M +1 -1 lib/documentview/documentviewcontroller.h M +5 -5 lib/documentview/documentviewsynchronizer.cpp M +1 -1 lib/documentview/documentviewsynchronizer.h M +6 -6 lib/documentview/rasterimageview.cpp M +7 -7 lib/documentview/rasterimageviewadapter.cpp M +3 -3 lib/documentview/rasterimageviewadapter.h M +9 -9 lib/documentview/svgviewadapter.cpp M +3 -3 lib/documentview/svgviewadapter.h M +13 -12 lib/zoomwidget.cpp M +1 -1 lib/zoomwidget.h https://commits.kde.org/gwenview/ba63c8a44f463b883c03c77c942809cd238a6594 Pretty amazing - 9 years after I filed this :) Thanks! You have to thank Silas, I only added the JJ tag ;) |