| Summary: | Implement a selective saturation filter [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Julien Narboux <Julien> |
| Component: | Plugin-Editor-HSL | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | 1.7.0 | |
| Sentry Crash Report: | |||
| Attachments: |
A patch to add a slider called "selective saturation" in hsl plugin
First version of a patch to add a vibrance slider to HSL tool. |
||
|
Description
Julien Narboux
2009-06-07 14:28:05 UTC
Created attachment 34345 [details]
A patch to add a slider called "selective saturation" in hsl plugin
This patch adds a slider in hsl tool. The new slider is supposed to add saturation mostly to pixels whose saturation is low.
This intent is to have something similar to the so called "vibrance" setting in some other software.
Preserving skin tones can not be done easily without changing deeply the current implementation of hsl, because the implementation is such that when changing saturation we do not have access to hue directly.
I did not commit this patch because I am not satisfied with the results. The algorithm needs a deeper study.
Julien
Some screenshots: http://www.flickr.com/photos/julien_narboux/sets/72157619379393970/ Comments welcome. Julien Julien, I have completely forget this patch. Somebody can review it, and give us viewpoint, as photograph... Thanks in advance Gilles Gilles, I have to work on this. This patch only saturate more low saturated pixel. We need, in addition to saturate less colors whose hue component are similar to skin tone.... Julien Created attachment 42288 [details]
First version of a patch to add a vibrance slider to HSL tool.
This patch creates a new slider called vibrance in the HSL tool. This slider is the same as saturation except that it adds saturation only to a special range of colors whose hue is in a given range. The range is set to try to avoid saturating skin tones.
TODO: add interpolation: for the time begin saturation is added to a given range of hue, in the future saturation should be added more to some hue rand and less to some others but with smooth transition.
SVN commit 1108522 by jnarboux: First version of the vibrance slider in the HSL tool. CCBUGS: 195561 M +31 -5 hslfilter.cpp M +5 -1 hslfilter.h M +28 -8 hslsettings.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1108522 SVN commit 1108530 by cgilles: HSL correction tool is also available in Batch Queue Manager. Don't forget to patch Vibrance management settings here, else, settings widget adjustment done by user will be ignored, and default value will be used instead. CCBUGS: 195561 M +4 -0 hslcorrection.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1108530 What's the status of this report? Has it been fixed? Well, if BQM HSL tool has the same settings than IE HSL tool, so yes, this file can be closed. Gilles Caulier The settings are the same in BQM. I mark the bug as fixed. |